Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.4.0-rc1
Choose a base ref
...
head repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.4.0-rc2
Choose a head ref
  • 3 commits
  • 25 files changed
  • 1 contributor

Commits on Apr 24, 2025

  1. fix: use the python micro version to parse whl metadata in bzlmod (#2793 

    )

Add `<micro>` version to the target platform. Instead of `cpxy_os_cpu`
the target platform string format becomes `cpxy.z_os_cpu`. This is a
temporary measure until we get a better API for defining target
platforms.

Summary:
- [x] test `select_whls` function needs to be tested to ensure that the
  whl selection is not impacted when we have the full version in the
  target platform.
- [ ] `download_only` legacy whl code path in `bzlmod` needs further
  testing.
- [x] test `whl_config_setting` handling and config setting creation.
  The config settings in the hub repo should not use the full version,
  because from the outside, the whl is compatible with all `micro`
  versions of a given `3.<minor_version>` of the Python interpreter.
  This means that the already documented config setting do not need to
  be changed.
- [x] `pep508_deps` tests for handling the `full_python_version`
  correctly.
- [x] `pep508_deps` tests for ensuring the `default_abi` is being
  handled correctly.

Fixes #2319

(cherry picked from commit 1e21dbd)
    @aignas @rickeylev
    aignas authored and rickeylev committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    be79b5e View commit details
    Browse the repository at this point in the history

  2. fix(pypi): call python --version before marker eval (#2819) 

    `bzlmod` has the full python version information statically and we don't
need to call Python to get its version, but for `WORKSPACE` that is not
the case and we have to call it before evaluating the markers in
universal requirements files.

This also fixes transitions in the `compile_pip_requirements` macro
where
the `.update` target would not transition correctly based on the
`python_version` parameter.

Fixes #2818

(cherry picked from commit ee34409)
    @aignas @rickeylev
    aignas authored and rickeylev committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    5605215 View commit details
    Browse the repository at this point in the history

  3. chore: remove a stray file (#2795) 

    Remove a stray file

(cherry picked from commit c981569)
    @aignas @rickeylev
    aignas authored and rickeylev committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    6a7ef8b View commit details
    Browse the repository at this point in the history
Loading