Skip to content

Add the twine tool to our internal toolchain #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexeagle opened this issue Jan 26, 2023 · 2 comments
Closed

Add the twine tool to our internal toolchain #1016

alexeagle opened this issue Jan 26, 2023 · 2 comments
Labels
Can Close? Will close in 30 days if there is no new activity

Comments

@alexeagle
Copy link
Contributor

We fetch some packages to support the pip_parse rule
https://github.com/bazelbuild/rules_python/blob/996025317896846267c40ef1934b9e71e3445e8b/python/pip_install/repositories.bzl#L7-L78
which users have to install for us in their WORKSPACE, either with

load("@rules_python//python/pip_install:repositories.bzl", "pip_install_dependencies")
pip_install_dependencies()

or just by calling pip_parse from their WORKSPACE which also does this.

Now I'm adding support under #99 for publishing packages, and per the official documentation https://packaging.python.org/en/latest/tutorials/packaging-projects/#uploading-the-distribution-archives the twine utility is recommended for doing this.

Therefore we ought to fetch that tool. We'd have to decide whether we always do that under pip_install_dependencies along with the others, even though install and publish are really separate concerns. OR, users who want to publish would need to be told to add another incantation to WORKSPACE to fetch the twine tool. We also have to update the bzlmod example to match whatever we do.
@alexeagle alexeagle mentioned this issue Feb 12, 2023
Merged
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Jul 25, 2023
@github-actions
Copy link

This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

@rickeylev rickeylev mentioned this issue Nov 13, 2023
Closed
@alexeagle alexeagle mentioned this issue Sep 17, 2024
Merged
mark-thm pushed a commit to theoremlp/rules_uv that referenced this issue Sep 23, 2024
@alexeagle
feat: add syntax sugar to avoid meaningless requirements.in files (#134)
1f92655 
This is a minor quality-of-life improvement for some cases, like
bazel-contrib/rules_python#1016 where you just
need a requirements file for the `twine` package so it's nice to write
it as

```
uv_pip_compile(
    name = "twine_requirements",
    requirements_in = ["twine"],
    requirements_txt = "requirements.twine",
)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Can Close? Will close in 30 days if there is no new activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexeagle