Skip to content

breaking change in 0.4.0 excluding tests/ folders in wheels #538

Closed
@alexeagle

Description

@alexeagle

in 0.4.0 we released this breaking change
7609526

However the tables library imports its own tests 🙄

https://github.com/PyTables/PyTables/blob/v3.6.1/tables/__init__.py#L148

Running bazel test :pandas_test in this repro https://github.com/UebelAndre/rules_python_regression illustrates the problem, and commenting out that line in tables fixes it.

So the question is what to do:

  1. only revert the breaking change
  2. add some opt-in or opt-out behavior all the way up at pip_install or pip_import that is wired into the BUILD file generation, turning this change on for all wheels
  3. make it more fine-grained, such that users configure specific libraries to have the tests folder excluded
  4. generalize the feature like in rules_nodejs where users can give us snippets to replace/extend the content of generated BUILD files for certain wheels. Then when some tests/ files collide with your first-party code you have to give us explicit BUILD file for that library

@mattem this was originally your feature, any opinions?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions