Closed
Description
in 0.4.0 we released this breaking change
7609526
However the tables
library imports its own tests 🙄
https://github.com/PyTables/PyTables/blob/v3.6.1/tables/__init__.py#L148
Running bazel test :pandas_test
in this repro https://github.com/UebelAndre/rules_python_regression illustrates the problem, and commenting out that line in tables fixes it.
So the question is what to do:
- only revert the breaking change
- add some opt-in or opt-out behavior all the way up at
pip_install
orpip_import
that is wired into the BUILD file generation, turning this change on for all wheels - make it more fine-grained, such that users configure specific libraries to have the tests folder excluded
- generalize the feature like in rules_nodejs where users can give us snippets to replace/extend the content of generated BUILD files for certain wheels. Then when some tests/ files collide with your first-party code you have to give us explicit BUILD file for that library
@mattem this was originally your feature, any opinions?
Metadata
Metadata
Assignees
Labels
No labels