Skip to content

fix(gazelle): handle purelib and platlib packages that don't set 'Root-Is-Purelib: true' #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

mattem
Copy link
Contributor

@mattem mattem commented Jul 26, 2022

Wheels can contain their package within the .data directory, inside the purelib or platlib directories, which is then unpacked into the correct site-packages folder.

Previously these directories were ignored, but this causes issues with packages such as semgrep that don't set Root-Is-Purelib: true and instead have the purelib directory under the .data package.

This is the same as setting Root-Is-Purelib: true and having all the files at the root, so I'm unsure of the reasons to do it this way 🤷

This results in the package being missing from the gazelle_python manifest files, and therefore causing issues with resolving dependencies.

@mattem mattem requested a review from f0rmiga as a code owner July 26, 2022 20:25
@mattem mattem force-pushed the fix/what-s-the-deal-with-purelib-vs-platlib branch from 33a136f to b164771 Compare August 10, 2022 21:16
@alexeagle alexeagle merged commit c9b70d1 into main Aug 10, 2022
@mattem mattem deleted the fix/what-s-the-deal-with-purelib-vs-platlib branch August 11, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants