generate py_test without __test__ #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0rmiga
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
I know at least a few repositories that this will be a breaking change. I've seen files using these patterns to contain test utilities and be reused by multiple tests. Ideally, those should be renamed to adhere to better practices. Having said that, we will need warning notes on the next release. cc @groodt @rickeylev
f0rmiga
pushed a commit
that referenced
this pull request
Apr 8, 2023
Since #999, gazelle can generate multiple `py_test` rules in a single package (when it finds multiple `*_test.py` or `test_*.py` files and no `__test__.py` file). In this case, adding new test files to a package with pre-existing `py_test` rules is not handled properly due to the `MatchAny` property on the `py_test` kind - it will match the existing `py_test` rule and edit it instead of adding a new test rule. This PR disables the matching so that new `py_test` rules are properly generated.
1 task
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Gazelle extension requires the existence of
__test__.pyor a target named__test__to generatepy_testtargets. Otherwise, all_test.pyandtest_*.pywill be included intopy_library.Issue Number: #714
What is the new behavior?
__test__.pyis not part of official Python specification. In fact, it is rarely used in existing open source Python projects. A more common scenario is to have_test.pyortest_*.pyfiles, each with something like:This PR creates a
py_testtarget per test Python file when neither__test__.pyor a target named__test__exists.Does this PR introduce a breaking change?
Other information