fix sub window engine didn't shut down after window closed. close MixinNetwork#123

boyan01 · boyan01 · commit f33938c80570 · 2022-07-27T16:36:34.000+08:00
diff --git a/packages/desktop_multi_window/macos/Classes/FlutterWindow.swift b/packages/desktop_multi_window/macos/Classes/FlutterWindow.swift
@@ -79,13 +79,25 @@ class FlutterWindow: BaseFlutterWindow {
     window.titleVisibility = .hidden
     window.titlebarAppearsTransparent = true
   }
-}
 
-extension FlutterWindow: NSWindowDelegate {
-  func windowWillClose(_ notification: Notification) {
+  deinit {
+    debugPrint("release window resource")
     window.delegate = nil
+    if let flutterViewController = window.contentViewController as? FlutterViewController {
+      flutterViewController.engine.shutDownEngine()
+    }
     window.contentViewController = nil
     window.windowController = nil
+  }
+}
+
+extension FlutterWindow: NSWindowDelegate {
+  func windowWillClose(_ notification: Notification) {
+    delegate?.onClose(windowId: windowId)
+  }
+
+  func windowShouldClose(_ sender: NSWindow) -> Bool {
     delegate?.onClose(windowId: windowId)
+    return true
   }
 }
