add todo

lobsterkatie · lobsterkatie · commit ef4f99f7566d · 2020-09-09T18:14:10.000-07:00
diff --git a/packages/node/src/integrations/http.ts b/packages/node/src/integrations/http.ts
@@ -101,6 +101,9 @@ function _createWrappedHandlerMaker(
         return originalHandler.apply(this, arguments);
       }
 
+      // TODO(kmclb): The cache below mirrors the one on the browser side, but in a node context it may actually break
+      // things, so figure that out and consider removing it
+
       // apply user-provided filter (if any) and cache result for next time
       const spanDecisionCache: { [key: string]: boolean } = {};
       const shouldStartSpan = (url: string): boolean => {

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,9 @@ function _createWrappedHandlerMaker(`
`101`	`101`	`return originalHandler.apply(this, arguments);`
`102`	`102`	`}`
`103`	`103`
	`104`	`+ // TODO(kmclb): The cache below mirrors the one on the browser side, but in a node context it may actually break`
	`105`	`+ // things, so figure that out and consider removing it`
	`106`	`+`
`104`	`107`	`// apply user-provided filter (if any) and cache result for next time`
`105`	`108`	`const spanDecisionCache: { [key: string]: boolean } = {};`
`106`	`109`	`const shouldStartSpan = (url: string): boolean => {`