bug symfony#3541 Update generic_event.rst (Lumbendil)

weaverryan · weaverryan · commit d27530241cf7 · 2014-02-11T12:04:34.000-06:00
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#3541). Discussion ---------- Update generic_event.rst The $event['data'] field was not set, thus it wouldn't be modified. Also, the example already had a lowercase string. Uppercased 1 letter. Commits ------- 029f4e1 Update generic_event.rst
diff --git a/components/event_dispatcher/generic_event.rst b/components/event_dispatcher/generic_event.rst
@@ -93,7 +93,7 @@ Filtering data::
 
     use Symfony\Component\EventDispatcher\GenericEvent;
 
-    $event = new GenericEvent($subject, array('data' => 'foo'));
+    $event = new GenericEvent($subject, array('data' => 'Foo'));
     $dispatcher->dispatch('foo', $event);
 
     echo $event['data'];
@@ -102,6 +102,6 @@ Filtering data::
     {
         public function filter(GenericEvent $event)
         {
-            strtolower($event['data']);
+            $event['data'] = strtolower($event['data']);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ Filtering data::`
`93`	`93`
`94`	`94`	`use Symfony\Component\EventDispatcher\GenericEvent;`
`95`	`95`
`96`		`- $event = new GenericEvent($subject, array('data' => 'foo'));`
	`96`	`+ $event = new GenericEvent($subject, array('data' => 'Foo'));`
`97`	`97`	`$dispatcher->dispatch('foo', $event);`
`98`	`98`
`99`	`99`	`echo $event['data'];`
`@@ -102,6 +102,6 @@ Filtering data::`
`102`	`102`	`{`
`103`	`103`	`public function filter(GenericEvent $event)`
`104`	`104`	`{`
`105`		`- strtolower($event['data']);`
	`105`	`+ $event['data'] = strtolower($event['data']);`
`106`	`106`	`}`
`107`	`107`	`}`