forked from angular-schule/ngx-deploy-starter
-
-
Notifications
You must be signed in to change notification settings - Fork 15
Closed
Description
Hi Diego,
Today I noticed two details about the buildTarget
option, which imho should be modified for (1) improved understanding and (2) flexibility. These are:
- The option called
buildTarget
is actually only modifying the build target configuration. In the end, you call the NX devkit to run something likenx run my-module:my-build-target:my-configuration
, and this parameter only modifies the third part of this string. I would expect that, being namedbuildTarget
, it modifies themy-build-target
part, not themy-configuration
part. - I see that you have hardcoded the word build in the code. In most of the cases, the build target of projects will be called
build
, but what if they're not? I am having issues with the nx-devkit right now, because it won't correctly run the target if it depends on other targets. In my case, I have to run something likebuild-npm-library
instead of the standardbuild
, and because this value is hardcoded in this plugin, I can't even modify it by passing it as an option.
I know that changing these is a breaking change, but semantically would make a lot of sense.
Thank you in advance, and congratulations for the great plugin
Metadata
Metadata
Assignees
Labels
No labels