add persistent option to allow automatic connection closing

binarycode · ioquatix · commit 0905976fd9e1 · 2020-01-22T13:06:08.000+13:00
diff --git a/lib/async/http/faraday/adapter.rb b/lib/async/http/faraday/adapter.rb
@@ -25,14 +25,12 @@
 module Async
 	module HTTP
 		module Faraday
-			# Detect whether we can use persistent connections:
-			PERSISTENT = ::Faraday::Connection.instance_methods.include?(:close)
-			
 			class Adapter < ::Faraday::Adapter
 				def initialize(*arguments, **options, &block)
 					super
 					
 					@internet = Async::HTTP::Internet.new
+					@persistent = ::Faraday::Connection.instance_methods.include?(:close) && options.fetch(:persistent, true)
 				end
 				
 				def close
@@ -49,7 +47,7 @@ def call(env)
 					return @app.call(env)
 				ensure
 					# Don't retain persistent connections unless they will eventually be closed:
-					@internet.close unless PERSISTENT
+					@internet.close unless @persistent
 				end
 			end
 		end
diff --git a/spec/async/http/faraday/adapter_spec.rb b/spec/async/http/faraday/adapter_spec.rb
@@ -91,4 +91,13 @@ def get_response(url, path)
 			expect(response.body).to be_nil
 		end
 	end
+
+	it 'closes connection automatically if persistent option is set to false' do
+		run_server(Protocol::HTTP::Response[204]) do
+			Faraday.new(url: endpoint.url) do |faraday|
+				faraday.response :logger
+				faraday.adapter :async_http, persistent: false
+			end.get('/index')
+		end
+	end
 end
