use Async::RSpec::Reactor to detect socket leaks

binarycode · ioquatix · commit 314210f4ea13 · 2019-10-24T23:35:26.000+13:00
diff --git a/spec/async/http/faraday/adapter_spec.rb b/spec/async/http/faraday/adapter_spec.rb
@@ -25,6 +25,8 @@
 require 'async'
 
 RSpec.describe Async::HTTP::Faraday::Adapter do
+	include_context Async::RSpec::Reactor
+
 	let(:endpoint) {
 		Async::HTTP::Endpoint.parse('http://127.0.0.1:9294')
 	}
@@ -86,25 +88,4 @@ def get_response(url, path)
 			expect(response.body).to be_nil
 		end
 	end
-
-	if RbConfig::CONFIG['host_os'] =~ /linux/
-		it 'does not leak sockets' do
-			def get_socket_count
-				`ls -l /proc/#{$$}/fd | grep socket | wc -l`.to_i
-			end
-
-			REQUEST_COUNT = 3
-
-			run_server(Protocol::HTTP::Response[204]) do
-				# warm up
-				get_response(endpoint.url, '/index')
-
-				sockets_before = get_socket_count
-				REQUEST_COUNT.times { get_response(endpoint.url, '/index') }
-				sockets_after = get_socket_count
-
-				expect(sockets_after).to eq sockets_before
-			end
-		end
-	end
 end
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,4 +1,5 @@
 
+require 'async/rspec'
 require 'covered/rspec'
 
 RSpec.configure do |config|
