Skip to content

Commit ac6ff4e

Browse files
committed
use VCR for spec that is calling remote server
1 parent f45e611 commit ac6ff4e

File tree

4 files changed

+69
-4
lines changed

4 files changed

+69
-4
lines changed

async-http-faraday.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,5 @@ Gem::Specification.new do |spec|
2525
spec.add_development_dependency "bundler"
2626
spec.add_development_dependency "rspec", "~> 3.6"
2727
spec.add_development_dependency "rake"
28+
spec.add_development_dependency "vcr"
2829
end

spec/async/http/faraday/adapter_spec.rb

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424

2525
require 'async'
2626

27+
require 'vcr_helper'
28+
2729
RSpec.describe Async::HTTP::Faraday::Adapter do
2830
include_context Async::RSpec::Reactor
2931

@@ -66,11 +68,13 @@ def get_response(url, path)
6668
end
6769
end
6870

69-
it "can get remote resource" do
71+
it 'can get remote resource' do
7072
Async do
71-
response = get_response('http://www.google.com', '/search?q=cats')
72-
73-
expect(response).to be_success
73+
VCR.use_cassette('remote') do
74+
response = get_response('http://www.google.com', '/search?q=cats')
75+
76+
expect(response).to be_success
77+
end
7478
end
7579
end
7680

spec/cassettes/remote.yml

Lines changed: 46 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_helper.rb

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
require 'vcr'
2+
3+
VCR.configure do |config|
4+
config.cassette_library_dir = 'spec/cassettes'
5+
config.hook_into :faraday
6+
config.ignore_localhost = true
7+
end
8+
9+
# support Faraday::Adapter#close until PR https://github.com/vcr/vcr/pull/793 is merged
10+
class VCR::Middleware::Faraday
11+
def close
12+
@app.close
13+
end
14+
end

0 commit comments

Comments
 (0)