fix leaking sockets

binarycode · ioquatix · commit e2540af4eb90 · 2019-10-24T23:35:26.000+13:00
diff --git a/lib/async/http/faraday/adapter.rb b/lib/async/http/faraday/adapter.rb
@@ -36,6 +36,8 @@ def call(env)
 					save_response(env, response.status, response.read, response.headers)
 					
 					@app.call env
+				ensure
+					client.close if client
 				end
 				
 				def endpoints_for(env)
diff --git a/spec/async/http/faraday/adapter_spec.rb b/spec/async/http/faraday/adapter_spec.rb
@@ -86,4 +86,24 @@ def get_response(url, path)
 			expect(response.body).to be_nil
 		end
 	end
+
+	if RbConfig::CONFIG['host_os'] =~ /linux/
+		it 'does not leak sockets' do
+			def get_socket_count
+				`ls -l /proc/#{$$}/fd | grep socket | wc -l`.to_i
+			end
+
+			REQUEST_COUNT = 100
+
+			run_server(Protocol::HTTP::Response[204]) do
+				sockets_before = get_socket_count
+
+				REQUEST_COUNT.times { get_response(endpoint.url, '/index') }
+
+				sockets_after = get_socket_count
+
+				expect(sockets_after - sockets_before).to be < REQUEST_COUNT
+			end
+		end
+	end
 end
