first set of proposed changed with a import config setting

Sergio Freire · Sergio Freire · commit 27e81473b7f0 · 2019-10-22T11:47:59.000+01:00
diff --git a/atest/acceptance/resource.robot b/atest/acceptance/resource.robot
@@ -1,5 +1,5 @@
 *** Setting ***
-Library           SeleniumLibrary    run_on_failure=Nothing    implicit_wait=0.2 seconds    plugins=RunningKeyword.RunningKeyword
+Library           SeleniumLibrary    run_on_failure=Nothing    implicit_wait=0.2 seconds    plugins=RunningKeyword.RunningKeyword    embed_screenshots=True
 Library           Collections
 Library           OperatingSystem
 Library           DateTime
diff --git a/src/SeleniumLibrary/__init__.py b/src/SeleniumLibrary/__init__.py
@@ -405,7 +405,7 @@ class SeleniumLibrary(DynamicCore):
 
     def __init__(self, timeout=5.0, implicit_wait=0.0,
                  run_on_failure='Capture Page Screenshot',
-                 screenshot_root_directory=None, plugins=None,
+                 screenshot_root_directory=None, embed_screenshots=False, plugins=None,
                  event_firing_webdriver=None):
         """SeleniumLibrary can be imported with several optional arguments.
 
@@ -431,6 +431,7 @@ def __init__(self, timeout=5.0, implicit_wait=0.0,
             = RunOnFailureKeywords.resolve_keyword(run_on_failure)
         self._running_on_failure_keyword = False
         self.screenshot_root_directory = screenshot_root_directory
+        self.embed_screenshots = embed_screenshots
         self._element_finder = ElementFinder(self)
         self._plugin_keywords = []
         libraries = [
diff --git a/src/SeleniumLibrary/keywords/screenshot.py b/src/SeleniumLibrary/keywords/screenshot.py
@@ -15,16 +15,38 @@
 # limitations under the License.
 
 import os
+from os.path import basename
 
 from robot.utils import get_link_path
 
 from SeleniumLibrary.base import LibraryComponent, keyword
 from SeleniumLibrary.utils import is_noney
 from SeleniumLibrary.utils.path_formatter import _format_path
-
+import base64
 
 class ScreenshotKeywords(LibraryComponent):
 
+    @keyword
+    def set_embed_screenshots(self, embed_screenshots):
+        """Sets the directory for captured screenshots.
+
+        ``path`` argument specifies the absolute path to a directory where
+        the screenshots should be written to. If the directory does not
+        exist, it will be created. The directory can also be set when
+        `importing` the library. If it is not configured anywhere,
+        screenshots are saved to the same directory where Robot Framework's
+        log file is written.
+
+        The previous value is returned and can be used to restore
+        the original value later if needed.
+
+        Returning the previous value is new in SeleniumLibrary 3.0.
+        The persist argument was removed in SeleniumLibrary 3.2.
+        """
+        previous = self.ctx.embed_screenshots
+        self.ctx.embed_screenshots = path
+        return previous
+
     @keyword
     def set_screenshot_directory(self, path):
         """Sets the directory for captured screenshots.
@@ -148,3 +170,8 @@ def _embed_to_log(self, path, width):
         self.info('</td></tr><tr><td colspan="3">'
                   '<a href="{src}"><img src="{src}" width="{width}px"></a>'
                   .format(src=get_link_path(path, self.log_dir), width=width), html=True)
+        self.info('screenshots:{s}'.format(s=self.ctx.embed_screenshots))
+        if self.ctx.embed_screenshots:
+            data = open(path, "r").read()
+            self.info('<a href="{src}" download="{basename}"><img src="data:image/png;base64,{encodedfile}" width="{width}px"></a>'
+                      .format(src=get_link_path(path, self.log_dir), encodedfile=base64.b64encode(data), basename=basename(path), width=width), html=True)
