Test that tests skipped due to a failure do not initiate exit-on-failure.

pekkaklarck · pekkaklarck · commit 23b12b0dc2f1 · 2020-10-18T22:54:47.000+03:00
Also avoid using deprecated --critical option.
diff --git a/atest/robot/cli/runner/exit_on_failure.robot b/atest/robot/cli/runner/exit_on_failure.robot
@@ -1,6 +1,6 @@
 *** Settings ***
 Suite Setup       Run Tests
-...               --exitonfailure --critical critical
+...               --exitonfailure --skiponfailure skip-on-failure
 ...               cli/runner/exit_on_failure.robot misc/suites running/fatal_exception/02__irrelevant.robot
 Resource          atest_resource.robot
 
@@ -12,9 +12,12 @@ Passing tests do not initiate exit-on-failure
     Check Test Case    Passing
     Check Test Case    Passing tests do not initiate exit-on-failure
 
+Skip-on-failure tests do not initiate exit-on-failure
+    Check Test Case    Skipped on failure
+
 Failing tests initiate exit-on-failure
     Check Test Case    Failing
-    Test Should Have Been Skipped    Skipped
+    Test Should Have Been Skipped    Not executed
 
 Tests in subsequent suites are skipped
     Test Should Have Been Skipped    SubSuite1 First
diff --git a/atest/testdata/cli/runner/exit_on_failure.robot b/atest/testdata/cli/runner/exit_on_failure.robot
@@ -1,16 +1,22 @@
-*** Settings ***
-Default Tags        critical
-
 *** Test Cases ***
 Passing
     No Operation
 
 Passing tests do not initiate exit-on-failure
     No Operation
 
+Skipped on failure
+    [Documentation]    SKIP
+    ...       Test failed but its tags matched '--SkipOnFailure' and it was marked skipped.
+    ...
+    ...       Original failure:
+    ...       Does not initiate exit-on-failure
+    [Tags]    skip-on-failure
+    Fail    Does not initiate exit-on-failure
+
 Failing
-    [Documentation]    FAIL initiates exit-on-failure
-    Fail    initiates exit-on-failure
+    [Documentation]    FAIL Initiates exit-on-failure
+    Fail    Initiates exit-on-failure
 
-Skipped
+Not executed
     Fail    Not executed
