fix(utils/get): handle case when nested value is falsy (#2982)

jonfunkhouser · tmorehouse · commit 40f6cb7c11d5 · 2019-04-02T00:22:41.000-03:00
diff --git a/src/utils/get.js b/src/utils/get.js
@@ -37,7 +37,7 @@ const get = (obj, path, defaultValue = null) => {
   }
 
   // Traverse path in object to find result
-  return steps.every(step => isObject(obj) && obj.hasOwnProperty(step) && (obj = obj[step]))
+  return steps.every(step => isObject(obj) && obj.hasOwnProperty(step) && (obj = obj[step]) != null)
     ? obj
     : defaultValue
 }
diff --git a/src/utils/get.spec.js b/src/utils/get.spec.js
@@ -19,13 +19,17 @@ describe('get', () => {
     expect(get({}, [], 0)).toBe(0)
     expect(get({ a: 'b' }, 'b', {})).toEqual({})
     expect(get({ a: { c: 'd' } }, 'a.d', [])).toEqual([])
+    expect(get({ a: { c: undefined } }, 'a.c')).toBe(null)
+    expect(get({ a: 0, b: false }, 'c')).toBe(null)
   })
 
   it('returns expected value', async () => {
     const obj1 = { a: 'b' }
     const obj2 = { a: { b: { c: { d: 'e' } } } }
     const obj3 = { a: [{ b: 'c' }] }
     const obj4 = { a: [[{ b: 'c' }], [{ d: { e: ['f'] } }]] }
+    const obj5 = { a: { b: 0, c: '', d: false } }
+    const obj6 = { a: 0, b: false }
 
     expect(get(obj1, 'a')).toBe('b')
     expect(get(obj1, ['a'])).toBe('b')
@@ -36,6 +40,11 @@ describe('get', () => {
     expect(get(obj4, 'a[1][0].d.e[0]')).toBe('f')
     expect(get(obj4, ['a', 1, 0, 'd', 'e', 0])).toBe('f')
     expect(get(obj4, ['a[1]', 0, 'd', 'e[0]'])).toBe('f')
+    expect(get(obj5, 'a.b')).toBe(0)
+    expect(get(obj5, 'a.c')).toBe('')
+    expect(get(obj5, 'a.d')).toBe(false)
+    expect(get(obj6, 'a')).toBe(0)
+    expect(get(obj6, 'b')).toBe(false)
   })
 
   it('handles when field name has dot', async () => {

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ const get = (obj, path, defaultValue = null) => {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`// Traverse path in object to find result`
`40`		`- return steps.every(step => isObject(obj) && obj.hasOwnProperty(step) && (obj = obj[step]))`
	`40`	`+ return steps.every(step => isObject(obj) && obj.hasOwnProperty(step) && (obj = obj[step]) != null)`
`41`	`41`	`? obj`
`42`	`42`	`: defaultValue`
`43`	`43`	`}`