Update mixin-sorting.js

tmorehouse · web-flow · commit 518231cd338b · 2019-10-17T18:40:16.000-03:00
diff --git a/src/components/table/helpers/mixin-sorting.js b/src/components/table/helpers/mixin-sorting.js
@@ -266,16 +266,20 @@ export default {
         //   handle toggling on the index
         if (key === sortBy) {
           // Change sorting direction on current column
-          this.localSortDesc[0] = !this.localSortDesc[0]
+          // this.localSortDesc[0] = !this.localSortDesc[0]
+          this.localSortDesc = [!this.localSortDesc[0]]
+          // TODO in this PR:
+          //   Check if sort is clearing (third click), and
+          //   if so remove the sort item from both localSortBy/localSortDesc
         } else {
           // Start sorting this column ascending
           this.localSortBy[0] = key
           // this.localSortDesc = false
           toggleLocalSortDesc()
         }
         sortChanged = true
-      } else if (this.localSortBy && !this.noSortReset) {
-        this.localSortBy = ['']
+      } else if (this.localSortBy.length > 0 && !this.noSortReset) {
+        this.localSortBy = []
         toggleLocalSortDesc()
         sortChanged = true
         // } else {
