Skip to content

Commit e84c4a7

Browse files
authored
fix(breadcrumb-item): remove role="presentation" (#2991)
1 parent 63985da commit e84c4a7

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

src/components/breadcrumb/breadcrumb-item.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ export default {
1111
'li',
1212
mergeData(data, {
1313
staticClass: 'breadcrumb-item',
14-
class: { active: props.active },
15-
attrs: { role: 'presentation' }
14+
class: { active: props.active }
1615
}),
1716
[h(BBreadcrumbLink, { props }, children)]
1817
)

src/components/breadcrumb/breadcrumb-item.spec.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ describe('breadcrumb-item', () => {
88
expect(wrapper.classes()).toContain('breadcrumb-item')
99
expect(wrapper.classes()).not.toContain('active')
1010
expect(wrapper.classes().length).toBe(1)
11-
expect(wrapper.attributes('role')).toBeDefined()
12-
expect(wrapper.attributes('role')).toBe('presentation')
1311
})
1412

1513
it('has class active when prop active is set', async () => {
@@ -22,8 +20,6 @@ describe('breadcrumb-item', () => {
2220
expect(wrapper.classes()).toContain('active')
2321
expect(wrapper.classes()).toContain('breadcrumb-item')
2422
expect(wrapper.classes().length).toBe(2)
25-
expect(wrapper.attributes('role')).toBeDefined()
26-
expect(wrapper.attributes('role')).toBe('presentation')
2723
})
2824

2925
it('has link as child', async () => {

0 commit comments

Comments
 (0)