Revert "fix(observedom): Callback not being called for changes other than childList changes (#1025)"

tmorehouse · web-flow · commit f5ac1d6cf25b · 2017-09-12T04:28:52.000-03:00
This reverts commit 88cfaef.
diff --git a/lib/utils/observe-dom.js b/lib/utils/observe-dom.js
@@ -1,6 +1,5 @@
 
-import { assign } from './object';
-
+import { assign } from '../utils/object';
 /**
  * Observe a DOM element changes, falls back to eventListener mode
  * @param {Element} el The DOM element to observe
@@ -15,42 +14,14 @@ export default function observeDOM(el, callback, opts) {
     if (MutationObserver) {
         // Define a new observer
         const obs = new MutationObserver(mutations => {
-            let changed = false;
-            // A Mutation can contain several changes, so we loop through them to see what has changed
-            // We break out of the loop early if any "significant" change has been detected
-            for (let i = 0; i < mutations.length && !changed; i++) {
-                // The muttion record
-                const mutation = mutations[i];
-                // Mutation Type
-                const type = mutation.type;
-                // DOM Node
-                const target = mutation.target;
-                // Previous Value (only for characterData and attributes)
-                const old = mutation.oldValue;
-                if (type === 'characterData' && target.nodeType === Node.TEXT_NODE && old !== target.data) {
-                    // We ignore nodes that are not TEXt (i.e. comments, etc) as they don't change layout
-                    // Updating character data with the same value still triggers a mutation
-                    // So we compare the old value to the new value
-                    changed = true;
-                } else if (type === 'attributes' && target.getAttribute(mutation.attributeName) !== old) {
-                    // Updating an attribute with the same value still triggers a mutation
-                    // So we compare the old value to the new value
-                    changed = true;
-                } else if (type === 'childList' && (mutation.addedNodes.length > 0 || mutation.removedNodes.length > 0)) {
-                    // This includes HTMLElement and Text Nodes being added/removed
-                    changed = true;
-                }
-            }
-            if (changed) {
-                // We only call the callback if a change that could affect layout/size truely happened.
+            if (mutations[0].addedNodes.length > 0 || mutations[0].removedNodes.length > 0) {
                 callback();
             }
         });
 
-        // Have the observer observe foo for changes in children, etc
+        // Have the observer observe foo for changes in children
         obs.observe(el, assign({childList: true, subtree: true}, opts));
     } else if (eventListenerSupported) {
-        // Legacy interface. most likely not used in modern browsers
         el.addEventListener('DOMNodeInserted', callback, false);
         el.addEventListener('DOMNodeRemoved', callback, false);
     }
