Skip to content

Collapse: collapsed class not persistent #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lianee opened this issue May 5, 2018 · 2 comments · Fixed by #2102
Closed

Collapse: collapsed class not persistent #1798

lianee opened this issue May 5, 2018 · 2 comments · Fixed by #2102

Comments

@lianee
Copy link
Contributor

lianee commented May 5, 2018

See this fiddle

the v-b-toggle directive sets the "collapsed" class of the button, that works well, click on the button and its title will change accordingly.

but... close the collapse, the title then correctly read "Open Collapse", then change the value in the input field... The "collapsed" class disappears, and the button now read "Close Collapse".
@lianee
Copy link
Contributor Author

lianee commented May 5, 2018

in fact, anything changing the class will rip the "collapsed" class
this time changing the variant prop of the button:
fiddle

@lianee lianee changed the title Collapse: collapsed class overwritten by :class Collapse: collapsed class not persistent May 5, 2018
@RomeroMsk
Copy link
Contributor

I'm experiencing the same issue. The collapsed class is not added back after changing the :class prop of a toggling element.

@lianee lianee mentioned this issue Oct 25, 2018
Merged
tmorehouse pushed a commit that referenced this issue Oct 25, 2018
@lianee @tmorehouse
fix(collapse/toggle): "collapsed" class cleared when component updated (
6d33cae 
#2102)

fix(collapse/toggle): "collapsed" class cleared when component updated. fixes #1798
This was referenced Mar 27, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(collapse/toggle): "collapsed" class cleared when component updated. fixes #1798
2 participants
@RomeroMsk @lianee