Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Sep 25, 2019

Describe the PR

Instead of using functional component wrappers

May address some of the performance issues on larger tables

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) performance

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Instead of using functional component wrappers
@tmorehouse tmorehouse added Type: Perf Status: WIP PR: Patch Requires patch version bump labels Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #4156 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4156      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files         238      237       -1     
  Lines        4468     4463       -5     
  Branches     1259     1259              
==========================================
- Hits         4462     4457       -5     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/components/table/th.js 100% <100%> (ø) ⬆️
src/components/table/td.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3a46c...24ebe6f. Read the comment docs.

@tmorehouse tmorehouse changed the title perf(tables): make b-th and b-td extend table-cell helper perf(tables): make b-th extend b-td instead of using functional wrappers Sep 25, 2019
@tmorehouse tmorehouse marked this pull request as ready for review September 25, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Perf Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants