Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jan 24, 2020

Describe the PR

Prevent un-necessary unbind/rebind when parent component updates, by checking if values have changed (modal ID or triiger element).

In some cases when the parent component re-rendered due to a state change on a click handler, the directive would rebind and the modal open event would not have a chance to emit.

Fixes #4669

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #4672 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4672      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         253      253              
  Lines        5259     5267       +8     
  Branches     1399     1401       +2     
==========================================
+ Hits         5255     5263       +8     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/directives/modal/modal.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a3ee1d...66aa7cd. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review January 24, 2020 16:11
@tmorehouse tmorehouse added PR: Patch Requires patch version bump Type: Fix labels Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal Does Not Pop Up When Using Button Directive When Version is > 2.0.0
2 participants