Skip to content

sidebar scss: redundant height declaration #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mmilano opened this issue Jul 24, 2020 · 0 comments · Fixed by #5606
Closed

sidebar scss: redundant height declaration #5605

mmilano opened this issue Jul 24, 2020 · 0 comments · Fixed by #5606

Comments

@mmilano
Copy link
Contributor

mmilano commented Jul 24, 2020

Describe the bug

_sidebar.scss has a redundant height declaration.

link

specific line in question:

bootstrap-vue/src/components/sidebar/_sidebar.scss

Line 29 in a704ccc

height: 100vh !important;

Additional

Line #29 "height: 100vh !important;" is redundant, since line #26 already defines the height.
In addition, the !important isn't needed.

Versions

  • BootstrapVue: latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove redundant height declaration for .b-sidebar (fixes #5605) ThoriumData/bootstrap-vue
1 participant
@mmilano