-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(perf): reactivity issues with bvAttrs
and bvListeners
(closes #5520)
#5753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/1ilrc8a4t |
Codecov Report
@@ Coverage Diff @@
## dev #5753 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 284 284
Lines 9571 9575 +4
Branches 2527 2530 +3
=========================================
+ Hits 9571 9575 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@Hiws @alfianwahid I don't know why the CodeSanbox CI was not picked up by this PR but I was able to confirm that the code from #5520 worked in the Payground fo the deployment preview. Edit: CodeSanbox is also available now https://codesandbox.io/s/bvtable-sortable-g6lyz-rc7py. |
bvAttrs
and bvListeners
(closes #5520)bvAttrs
and bvListeners
(closes #5520)
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d61d80f:
|
Describe the PR
This PR fixes reactivity issues with the cached
bvAttrs
andbvListeners
props that were introduced with #4825.The problem was that when no
$attrs
or$listeners
were defined initially, but added later on, the initially defined proxied prop itself was not updated which prevented components that used the the proxied props from properly being re-rendered.Closes #5520.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: