Skip to content
  • Sponsor bootstrap-vue/bootstrap-vue

  • Notifications You must be signed in to change notification settings
  • Fork 1.9k

Enhancement: More settings for BModal #5958

Closed
@vincentdh

Description

@vincentdh

Is your feature request related to a problem? Please describe...

Lots of BModal props are not globally configurable with the settings. This result in lots of repeating code if, in example, you don't want the modal to be closed on backdrop click in your application.

Describe the solution you'd like

Add the following properties to the BModal Settings:

  • centered
  • scrollable
  • button-size
  • no-stacking
  • no-fade
  • no-close-on-backdrop
  • no-close-on-esc
  • title-class
  • header-class
  • modal-class
  • dialog-class
  • content-class
  • body-class
  • footer-class
  • hide-header
  • hide-footer
  • hide-header-close
  • hide-backdrop
  • ok-only
  • ok-disabled
  • cancel-disabled

Describe alternatives you've considered

Create a custom modal that just call the BModal with the prefered default settings.

Activity

changed the title [-]Feature request: More settings for BModal[/-] [+]Enhancement: More settings for BModal[/+] on Oct 23, 2020
jacobmllr95

jacobmllr95 commented on Oct 25, 2020

@jacobmllr95
Member

@vincentdh The problem with adding all those additional props to the global config is that it boats the bundle quite a bit since the default config can't be minified.

We have to rethink the global settings implementation in BootstrapVue v3 anyway, so I would put this on hold for that.

added 2 commits that reference this issue on Nov 30, 2020
added 2 commits that reference this issue on Dec 14, 2020
added a commit that references this issue on Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Enhancement: More settings for BModal · Issue #5958 · bootstrap-vue/bootstrap-vue