Skip to content

BPagination - initial page count set twice. #6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Nesuarg opened this issue Dec 15, 2020 · 0 comments · Fixed by #6200
Closed

BPagination - initial page count set twice. #6199

Nesuarg opened this issue Dec 15, 2020 · 0 comments · Fixed by #6200
Labels
Status: Confirmed

Comments

@Nesuarg
Copy link

Nesuarg commented Dec 15, 2020

In pagination.js the page count is initial set 2 times in first in created() and again in mounted(). If this is solved an edge case issue, then then comment should be updated?
Note that I didn't find any bugs related to this.

bootstrap-vue/src/components/pagination/pagination.js

Lines 79 to 97 in 9722376

created() {
// Set the initial page count
this.localNumberOfPages = this.numberOfPages
// Set the initial page value
const currentPage = toInteger(this[MODEL_PROP_NAME], 0)
if (currentPage > 0) {
this.currentPage = currentPage
} else {
this.$nextTick(() => {
// If this value parses to `NaN` or a value less than `1`
// trigger an initial emit of `null` if no page specified
this.currentPage = 0
})
}
},
mounted() {
// Set the initial page count
this.localNumberOfPages = this.numberOfPages
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(b-pagination): don't set initial page count twice (closes #6199) bootstrap-vue/bootstrap-vue
2 participants
@jacobmllr95 @Nesuarg