Skip to content

BvTableField is missing the sortKey field #6352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dpash opened this issue Jan 25, 2021 · 0 comments · Fixed by #6355
Closed

BvTableField is missing the sortKey field #6352

dpash opened this issue Jan 25, 2021 · 0 comments · Fixed by #6355

Comments

@dpash
Copy link

dpash commented Jan 25, 2021

Describe the bug

PR #5746 added a sortKey field option. The typescript type definition was incorrectly updated to add this as a prop on the component rather than as a field in the BvTableField interface.

Steps to reproduce the bug

  1. Add a sortKey option to a field definition
  2. Compile
  3. 174:56 Type '{ key: string; sortable: true; label: string; sortKey: string; }' is not assignable to type 'string | ({ key: string; } & BvTableField)'.
    Object literal may only specify known properties, and 'sortKey' does not exist in type '{ key: string; } & BvTableField'.

Expected behavior

No compile error

Versions

Libraries:

  • BootstrapVue: 2.21.2
  • Bootstrap: 4.5.3
  • Vue: 2.6.12

Environment:

  • Device: Intel server
  • OS: Ubuntu 18.04
  • Browser: NA
  • Version: NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants