Skip to content

feat(form-radio-check): migrate to using provide/inject, add inline props #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 86 commits into from
Dec 7, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Dec 2, 2018

Description of Pull Request:

Migrates b-form-checkbox, b-form-radio, b-form-checkbox-group, and b-form-radio-group to use provide and inject for grouping detection.

  • Moves common code and render functions into mixins (reducing code base)
  • Adjusts custom-control structure to align with BS V4.1.3 new structure
  • Adds inline prop to form-checkbox and form-radio (Closes Standalone checkboxes/radios are always inline by default #2234)
  • Adds better support for b-form-radio to be used standalone mode (non group)
  • Supports button mode in standalone mode (non group)
  • New test suites using vue-test-utils

TODO:

  • validate form-checkbox functionality
  • validate form-radio functionality
  • validate form-checkbox-group functionality
  • validate form-radio-group functionality
  • form-checkbox tests
  • form-radio tests
  • form-checkbox-group tests
  • form-radio-group tests
  • documentation updates

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #2241 into dev will increase coverage by 1.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #2241     +/-   ##
=========================================
+ Coverage   65.98%   67.48%   +1.5%     
=========================================
  Files         158      160      +2     
  Lines        3063     3060      -3     
  Branches      846      841      -5     
=========================================
+ Hits         2021     2065     +44     
+ Misses        761      732     -29     
+ Partials      281      263     -18
Impacted Files Coverage Δ
src/utils/loose-index-of.js 100% <100%> (ø)
src/components/form-radio/form-radio.js 100% <100%> (+46.15%) ⬆️
src/mixins/form-radio-check.js 100% <100%> (+34.48%) ⬆️
src/mixins/form-radio-check-group.js 100% <100%> (ø)
src/components/form-radio/form-radio-group.js 100% <100%> (+21.42%) ⬆️
...rc/components/form-checkbox/form-checkbox-group.js 100% <100%> (+21.42%) ⬆️
src/components/form-checkbox/form-checkbox.js 100% <100%> (+60.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e620e07...9ccf343. Read the comment docs.

@tmorehouse tmorehouse mentioned this pull request Dec 7, 2018
89 tasks
@tmorehouse tmorehouse merged commit c0a68d5 into dev Dec 7, 2018
@tmorehouse tmorehouse deleted the tmorehouse/radio-check branch December 7, 2018 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone checkboxes/radios are always inline by default
1 participant