-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(form-radio-check): migrate to using provide/inject, add inline props #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2241 +/- ##
=========================================
+ Coverage 65.98% 67.48% +1.5%
=========================================
Files 158 160 +2
Lines 3063 3060 -3
Branches 846 841 -5
=========================================
+ Hits 2021 2065 +44
+ Misses 761 732 -29
+ Partials 281 263 -18
Continue to review full report at Codecov.
|
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
Migrates
b-form-checkbox
,b-form-radio
,b-form-checkbox-group
, andb-form-radio-group
to use provide and inject for grouping detection.inline
prop toform-checkbox
andform-radio
(Closes Standalone checkboxes/radios are always inline by default #2234)b-form-radio
to be used standalone mode (non group)vue-test-utils
TODO:
form-checkbox
functionalityform-radio
functionalityform-checkbox-group
functionalityform-radio-group
functionalityform-checkbox
testsform-radio
testsform-checkbox-group
testsform-radio-group
testsPR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes: