-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(docs): drop self-closing tags + build system improvements (fixes #2882) #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jacobmllr95
merged 13 commits into
bootstrap-vue:dev
from
jacobmllr95:fix-docs-self-closing-tags
Mar 27, 2019
Merged
fix(docs): drop self-closing tags + build system improvements (fixes #2882) #2893
jacobmllr95
merged 13 commits into
bootstrap-vue:dev
from
jacobmllr95:fix-docs-self-closing-tags
Mar 27, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2893 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 205 205
Lines 3293 3293
Branches 996 996
=======================================
Hits 2998 2998
Misses 213 213
Partials 82 82
Continue to review full report at Codecov.
|
tmorehouse
reviewed
Mar 22, 2019
tmorehouse
approved these changes
Mar 26, 2019
tmorehouse
approved these changes
Mar 27, 2019
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
This PR removes self-closing tags from the docs to avoid issues in online code editors.
eslint
support forjs
code block in Markdown files is also added.Fixes #2882.
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)and adding a new feature, break them into separate PRs if at all possible.
Conventional Commits naming convention (i.e.
"fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
"chore: fix typo in docs", etc). This is very important, as the
CHANGELOG
is generatedfrom these messages.
If new features/enhancement/fixes are added or changed:
package.json
for slot andevent changes)
keyboard only users? clickable items should be in the tab index, etc)
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:
suggestion issue first and wait for approval before working on it)