Skip to content

fix(dropdown): fix no-caret prop when dropleft (fixes #2909) #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2019

Conversation

tmorehouse
Copy link
Member

Description of Pull Request:

Fixes #2909

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #2910 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2910   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         202      202           
  Lines        3235     3235           
  Branches      972      972           
=======================================
  Hits         2937     2937           
  Misses        215      215           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b184e19...d59c9ef. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(dropdown): fix hide-caret when dropleft (fixes #2909) fix(dropdown): fix no-caret when dropleft (fixes #2909) Mar 25, 2019
@jacobmllr95 jacobmllr95 changed the title fix(dropdown): fix no-caret when dropleft (fixes #2909) fix(dropdown): fix noCaret prop when dropleft (fixes #2909) Mar 25, 2019
@jacobmllr95 jacobmllr95 self-requested a review March 25, 2019 13:26
@tmorehouse tmorehouse changed the title fix(dropdown): fix noCaret prop when dropleft (fixes #2909) fix(dropdown): fix no-caret prop when dropleft (fixes #2909) Mar 25, 2019
@jacobmllr95 jacobmllr95 merged commit 3bef981 into dev Mar 25, 2019
@jacobmllr95 jacobmllr95 deleted the tmorehouse/dropleft branch March 25, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

b-dropdown's no-carret prop has no effect when the dropleft prop is set
2 participants