Skip to content

chore(unit testing): dropdown tests #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Apr 1, 2019
Merged

Conversation

tmorehouse
Copy link
Member

Description of Pull Request:

Migrate to vue-test-utils

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe: unit testing

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #2974 into dev will increase coverage by 2.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2974      +/-   ##
==========================================
+ Coverage   92.23%   95.17%   +2.94%     
==========================================
  Files         205      205              
  Lines        3269     3297      +28     
  Branches      965      982      +17     
==========================================
+ Hits         3015     3138     +123     
+ Misses        187      121      -66     
+ Partials       67       38      -29
Impacted Files Coverage Δ
src/mixins/dropdown.js 100% <ø> (+91.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f2728...16d7add. Read the comment docs.

@bootstrap-vue bootstrap-vue deleted a comment from codecov bot Apr 1, 2019
@tmorehouse tmorehouse marked this pull request as ready for review April 1, 2019 20:47
@tmorehouse tmorehouse requested a review from jacobmllr95 April 1, 2019 20:47
@tmorehouse tmorehouse merged commit d9d4d88 into dev Apr 1, 2019
@tmorehouse tmorehouse deleted the tmorehouse/dropdown-tests branch April 1, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant