Skip to content

Fixed issues on tabs/tab #34 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2016
Merged

Fixed issues on tabs/tab #34 #37

merged 1 commit into from
Dec 7, 2016

Conversation

mathlef0u
Copy link
Contributor

https://vuejs.org/v2/guide/migration.html#vm-set-changed

I also moved active from props to data because :

[Vue warn]: Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "active" (found in component )

@pi0
Copy link
Member

pi0 commented Dec 7, 2016

@mathlet0x Awesome 👍

@pi0 pi0 merged commit ed7a87b into bootstrap-vue:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathlef0u @pi0