From 2cf6d254191451d54c16d65da91877b18286588d Mon Sep 17 00:00:00 2001 From: Troy Morehouse Date: Fri, 13 Sep 2019 19:06:34 -0300 Subject: [PATCH 01/21] chore(docs): fix table example typo (#4093) --- src/components/table/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/table/README.md b/src/components/table/README.md index 33a78bdc0c7..4ac0b0bf622 100644 --- a/src/components/table/README.md +++ b/src/components/table/README.md @@ -1039,7 +1039,7 @@ footer cells that do not have an explicit scoped slot provided. From 29b2bf377b1cc7ea05227deb03eed65dd9117714 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 14 Sep 2019 11:35:22 +0200 Subject: [PATCH 02/21] chore(deps): update devdependency eslint to ^6.4.0 (#4094) --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index f4a2c0891f6..029d565e46a 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,7 @@ "codesandbox": "^2.1.10", "core-js": ">=2.6.5 <3.0.0", "cross-env": "^5.2.1", - "eslint": "^6.3.0", + "eslint": "^6.4.0", "eslint-config-prettier": "^6.3.0", "eslint-config-standard": "^14.1.0", "eslint-config-vue": "^2.0.2", diff --git a/yarn.lock b/yarn.lock index 189882d5d54..311880bfde4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4816,10 +4816,10 @@ eslint-visitor-keys@^1.1.0: resolved "https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-1.1.0.tgz#e2a82cea84ff246ad6fb57f9bde5b46621459ec2" integrity sha512-8y9YjtM1JBJU/A9Kc+SbaOV4y29sSWckBwMHa+FGtVj5gN/sbnKDf6xJUl+8g7FAij9LVaP8C24DUiH/f/2Z9A== -eslint@^6.3.0: - version "6.3.0" - resolved "https://registry.yarnpkg.com/eslint/-/eslint-6.3.0.tgz#1f1a902f67bfd4c354e7288b81e40654d927eb6a" - integrity sha512-ZvZTKaqDue+N8Y9g0kp6UPZtS4FSY3qARxBs7p4f0H0iof381XHduqVerFWtK8DPtKmemqbqCFENWSQgPR/Gow== +eslint@^6.4.0: + version "6.4.0" + resolved "https://registry.yarnpkg.com/eslint/-/eslint-6.4.0.tgz#5aa9227c3fbe921982b2eda94ba0d7fae858611a" + integrity sha512-WTVEzK3lSFoXUovDHEbkJqCVPEPwbhCq4trDktNI6ygs7aO41d4cDT0JFAT5MivzZeVLWlg7vHL+bgrQv/t3vA== dependencies: "@babel/code-frame" "^7.0.0" ajv "^6.10.0" From 8c99a47f161de279609b5beba27dea2982776005 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 14 Sep 2019 15:03:09 -0300 Subject: [PATCH 03/21] chore(deps): update devdependency rollup to ^1.21.3 (#4096) --- package.json | 2 +- yarn.lock | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 029d565e46a..30f817bee73 100644 --- a/package.json +++ b/package.json @@ -123,7 +123,7 @@ "nuxt": "^2.9.2", "postcss-cli": "^6.1.3", "prettier": "1.14.3", - "rollup": "^1.21.2", + "rollup": "^1.21.3", "rollup-plugin-babel": "^4.3.3", "rollup-plugin-commonjs": "^10.1.0", "rollup-plugin-node-resolve": "^5.2.0", diff --git a/yarn.lock b/yarn.lock index 311880bfde4..0ed6f97918a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1576,10 +1576,10 @@ resolved "https://registry.yarnpkg.com/@types/node/-/node-12.6.1.tgz#d5544f6de0aae03eefbb63d5120f6c8be0691946" integrity sha512-rp7La3m845mSESCgsJePNL/JQyhkOJA6G4vcwvVgkDAwHhGdq5GCumxmPjEk1MZf+8p5ZQAUE7tqgQRQTXN7uQ== -"@types/node@^12.7.4": - version "12.7.4" - resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.4.tgz#64db61e0359eb5a8d99b55e05c729f130a678b04" - integrity sha512-W0+n1Y+gK/8G2P/piTkBBN38Qc5Q1ZSO6B5H3QmPCUewaiXOo2GCAWZ4ElZCcNhjJuBSUSLGFUJnmlCn5+nxOQ== +"@types/node@^12.7.5": + version "12.7.5" + resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.5.tgz#e19436e7f8e9b4601005d73673b6dc4784ffcc2f" + integrity sha512-9fq4jZVhPNW8r+UYKnxF1e2HkDWOWKM5bC2/7c9wPV835I0aOrVbS/Hw/pWPk2uKrNXQqg9Z959Kz+IYDd5p3w== "@types/q@^1.5.1": version "1.5.2" @@ -10619,13 +10619,13 @@ rollup-pluginutils@^2.8.1: dependencies: estree-walker "^0.6.1" -rollup@^1.21.2: - version "1.21.2" - resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.21.2.tgz#eaabd07d0bd309587ad8bebf731fca6fcb96f4d0" - integrity sha512-sCAHlcQ/PExU5t/kRwkEWHdhGmQrZ2IgdQzbjPVNfhWbKHMMZGYqkASVTpQqRPLtQKg15xzEscc+BnIK/TE7/Q== +rollup@^1.21.3: + version "1.21.3" + resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.21.3.tgz#2d957e04b230b06a85b8c617bf594f92c37c4d5d" + integrity sha512-43CgeUtHhfiqBOUd0uJo5NEOg2FuheF3SqGN8BqgvnqB4xM2TbfPdudeSdllDcMKpagHb//qtpaAADBurT4GzA== dependencies: "@types/estree" "0.0.39" - "@types/node" "^12.7.4" + "@types/node" "^12.7.5" acorn "^7.0.0" rsvp@^4.8.4: From 6468adf5e16fd87ec6067cda64e8f88eeb229bc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eddybrando=20V=C3=A1squez?= Date: Mon, 16 Sep 2019 14:35:59 +0200 Subject: [PATCH 04/21] docs(modal): fix trivial typo (#4104) Remove repeated "the" --- src/components/modal/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/modal/README.md b/src/components/modal/README.md index 799e72dcdae..890738720ba 100644 --- a/src/components/modal/README.md +++ b/src/components/modal/README.md @@ -27,7 +27,7 @@ using the `ok-title` and `cancel-title` props, or using the named slots `modal-o `` supports close on ESC (enabled by default), close on backdrop click (enabled by default), and the `X` close button in the header (enabled by default). These features may be -disabled by setting the the props `no-close-on-esc`, `no-close-on-backdrop`, and `hide-header-close` +disabled by setting the props `no-close-on-esc`, `no-close-on-backdrop`, and `hide-header-close` respectively. You can override the modal title via the named slot `modal-title`, override the header completely From b870a6de6b547387023be39e65a5e25a7cbf7015 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 16 Sep 2019 09:47:50 -0300 Subject: [PATCH 05/21] chore(deps): update devdependency rollup to ^1.21.4 (#4105) --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 30f817bee73..107d3d821da 100644 --- a/package.json +++ b/package.json @@ -123,7 +123,7 @@ "nuxt": "^2.9.2", "postcss-cli": "^6.1.3", "prettier": "1.14.3", - "rollup": "^1.21.3", + "rollup": "^1.21.4", "rollup-plugin-babel": "^4.3.3", "rollup-plugin-commonjs": "^10.1.0", "rollup-plugin-node-resolve": "^5.2.0", diff --git a/yarn.lock b/yarn.lock index 0ed6f97918a..0a28ee601ef 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10619,10 +10619,10 @@ rollup-pluginutils@^2.8.1: dependencies: estree-walker "^0.6.1" -rollup@^1.21.3: - version "1.21.3" - resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.21.3.tgz#2d957e04b230b06a85b8c617bf594f92c37c4d5d" - integrity sha512-43CgeUtHhfiqBOUd0uJo5NEOg2FuheF3SqGN8BqgvnqB4xM2TbfPdudeSdllDcMKpagHb//qtpaAADBurT4GzA== +rollup@^1.21.4: + version "1.21.4" + resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.21.4.tgz#00a41a30f90095db890301b226cbe2918e4cf54d" + integrity sha512-Pl512XVCmVzgcBz5h/3Li4oTaoDcmpuFZ+kdhS/wLreALz//WuDAMfomD3QEYl84NkDu6Z6wV9twlcREb4qQsw== dependencies: "@types/estree" "0.0.39" "@types/node" "^12.7.5" From 4309db53f614c15224299e9d8c8456b7b05fd908 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 18 Sep 2019 10:06:13 +0200 Subject: [PATCH 06/21] chore(deps): update devdependency eslint-plugin-prettier to ^3.1.1 (#4122) --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 107d3d821da..d7ea04cf0f3 100644 --- a/package.json +++ b/package.json @@ -106,7 +106,7 @@ "eslint-plugin-jest": "^22.17.0", "eslint-plugin-markdown": "^1.0.0", "eslint-plugin-node": "^10.0.0", - "eslint-plugin-prettier": "^3.1.0", + "eslint-plugin-prettier": "^3.1.1", "eslint-plugin-promise": "^4.2.1", "eslint-plugin-standard": "^4.0.1", "eslint-plugin-vue": "^5.2.3", diff --git a/yarn.lock b/yarn.lock index 0a28ee601ef..5c5749972dc 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4759,10 +4759,10 @@ eslint-plugin-node@^10.0.0: resolve "^1.10.1" semver "^6.1.0" -eslint-plugin-prettier@^3.1.0: - version "3.1.0" - resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.1.0.tgz#8695188f95daa93b0dc54b249347ca3b79c4686d" - integrity sha512-XWX2yVuwVNLOUhQijAkXz+rMPPoCr7WFiAl8ig6I7Xn+pPVhDhzg4DxHpmbeb0iqjO9UronEA3Tb09ChnFVHHA== +eslint-plugin-prettier@^3.1.1: + version "3.1.1" + resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.1.1.tgz#507b8562410d02a03f0ddc949c616f877852f2ba" + integrity sha512-A+TZuHZ0KU0cnn56/9mfR7/KjUJ9QNVXUhwvRFSR7PGPe0zQR6PTkmyqg1AtUUEOzTqeRsUwyKFh0oVZKVCrtA== dependencies: prettier-linter-helpers "^1.0.0" From 1bb47fd49fd4e42b44949d094614772f56cdbd53 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 18 Sep 2019 10:39:52 +0200 Subject: [PATCH 07/21] chore(deps): update devdependency cross-env to v6 (#4119) --- package.json | 2 +- yarn.lock | 21 +++++++++++++++------ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index d7ea04cf0f3..5e273a517a3 100644 --- a/package.json +++ b/package.json @@ -97,7 +97,7 @@ "codemirror": "^5.48.4", "codesandbox": "^2.1.10", "core-js": ">=2.6.5 <3.0.0", - "cross-env": "^5.2.1", + "cross-env": "^6.0.0", "eslint": "^6.4.0", "eslint-config-prettier": "^6.3.0", "eslint-config-standard": "^14.1.0", diff --git a/yarn.lock b/yarn.lock index 5c5749972dc..0fdfb24c7af 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3810,12 +3810,12 @@ create-hmac@^1.1.0, create-hmac@^1.1.2, create-hmac@^1.1.4: safe-buffer "^5.0.1" sha.js "^2.4.8" -cross-env@^5.2.1: - version "5.2.1" - resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-5.2.1.tgz#b2c76c1ca7add66dc874d11798466094f551b34d" - integrity sha512-1yHhtcfAd1r4nwQgknowuUNfIT9E8dOMMspC36g45dN+iD1blloi7xp8X/xAIDnjHWyt1uQ8PHk2fkNaym7soQ== +cross-env@^6.0.0: + version "6.0.0" + resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-6.0.0.tgz#3c8e71440ea20aa6faaf5aec541235efc565dac6" + integrity sha512-G/B6gtkjgthT8AP/xN1wdj5Xe18fVyk58JepK8GxpUbqcz3hyWxegocMbvnZK+KoTslwd0ACZ3woi/DVUdVjyQ== dependencies: - cross-spawn "^6.0.5" + cross-spawn "^7.0.0" cross-spawn@^3.0.0: version "3.0.1" @@ -3845,6 +3845,15 @@ cross-spawn@^6.0.0, cross-spawn@^6.0.5: shebang-command "^1.2.0" which "^1.2.9" +cross-spawn@^7.0.0: + version "7.0.0" + resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-7.0.0.tgz#21ef9470443262f33dba80b2705a91db959b2e03" + integrity sha512-6U/8SMK2FBNnB21oQ4+6Nsodxanw1gTkntYA2zBdkFYFu3ZDx65P2ONEXGSvob/QS6REjVHQ9zxzdOafwFdstw== + dependencies: + path-key "^3.1.0" + shebang-command "^1.2.0" + which "^1.2.9" + crypto-browserify@^3.11.0: version "3.12.0" resolved "https://registry.yarnpkg.com/crypto-browserify/-/crypto-browserify-3.12.0.tgz#396cf9f3137f03e4b8e532c58f698254e00f80ec" @@ -9018,7 +9027,7 @@ path-key@^2.0.0, path-key@^2.0.1: resolved "https://registry.yarnpkg.com/path-key/-/path-key-2.0.1.tgz#411cadb574c5a140d3a4b1910d40d80cc9f40b40" integrity sha1-QRyttXTFoUDTpLGRDUDYDMn0C0A= -path-key@^3.0.0: +path-key@^3.0.0, path-key@^3.1.0: version "3.1.0" resolved "https://registry.yarnpkg.com/path-key/-/path-key-3.1.0.tgz#99a10d870a803bdd5ee6f0470e58dfcd2f9a54d3" integrity sha512-8cChqz0RP6SHJkMt48FW0A7+qUOn+OsnOsVtzI59tZ8m+5bCSk7hzwET0pulwOM2YMn9J1efb07KB9l9f30SGg== From e35ad512f930c7d51d718d20ac77757158d82d6a Mon Sep 17 00:00:00 2001 From: Troy Morehouse Date: Wed, 18 Sep 2019 11:16:15 -0300 Subject: [PATCH 08/21] docs(table): document table `active` variant in selectable rows section (#4097) --- .../reference/color-variants/README.md | 37 ++++++++++--------- src/components/table/README.md | 11 +++++- 2 files changed, 29 insertions(+), 19 deletions(-) diff --git a/docs/markdown/reference/color-variants/README.md b/docs/markdown/reference/color-variants/README.md index 4a7ff7da237..4dba055c1be 100644 --- a/docs/markdown/reference/color-variants/README.md +++ b/docs/markdown/reference/color-variants/README.md @@ -16,7 +16,7 @@ - `dark` - Dark The base variants will translate to various Bootstrap v4 contextual class names based on the -component (and variant purpose) where they are used. +component (and variant purpose) where they are used. See the sections below for details. ## Background and border variants @@ -24,10 +24,10 @@ All the **base variants** plus: - `transparent` -These translate to class names `bg-` for backgrounds and `border-` for borders. +These translate to class names `bg-{variant}` for backgrounds and `border-{variant}` for borders. -These variants are used by components (such as ``, `` and ``) that -provide `bg-variant`, `*-bg-variant`, `border-variant` and `*-border-variant` props +These variants are used by components (such as ``, ``, ``, etc.) that +provide `bg-variant`, `*-bg-variant`, `border-variant` and `*-border-variant` props. ## Text variants @@ -37,10 +37,10 @@ All the **base variants** plus: - `white` - `black` -These translate to class names `text-` +These translate to class names `text-{variant}` -These variants are used by components (such as ``, `` and ``) that -provide `text-variant` and `*-text-variant` props +These variants are used by components (such as ``, ``, ``, etc.) that +provide `text-variant` and `*-text-variant` props. ## Component specific variants @@ -51,22 +51,22 @@ Some Bootstrap v4 components require additional CSS styling, or additional pseud All the **base variants** -These translate to class names `alert-`. +These translate to class names `alert-{variant}`. ### Badge variants All the **base variants** -These translate to class names `badge-`. +These translate to class names `badge-{variant}`. ### Button variants All the **base variants** plus: -- `outline-` -- `link` which renders the button with the look of a link but retains button padding and margins. +- `outline-{base variant}` which generates an outline button version of the base variant +- `link` which renders the button with the look of a link but retains button padding and margins -These translate to class names `btn-` and `btn-outline-`. +These translate to class names `btn-{variant}` and `btn-outline-{variant}`. Note the `link` variant does not have an outline version. @@ -76,27 +76,30 @@ All the **base variants** plus: - `active` -These variants translate to class names `table-`. +These variants translate to class names `table-{variant}`. -When the table has the `dark` prop set, the variants translate to the `bg-` classes. +When the table has the `dark` prop set, the variants translate to the `bg-{variant}` classes. + +Note that the `active` variant is only applicable to `` elements within the ``, and can +not be applied to individual table cells or used as the `table-variant`. ### Popover variants All the **base variants** -These translate to BootstrapVue custom class names `b-popover-`. +These translate to BootstrapVue custom class names `b-popover-{variant}`. ### Tooltip variants All the **base variants** -These translate to BootstrapVue custom class names `b-tooltip-`. +These translate to BootstrapVue custom class names `b-tooltip-{variant}`. ### Toast variants All the **base variants** -These translate to BootstrapVue custom class names `b-toast-`. +These translate to BootstrapVue custom class names `b-toast-{variant}`. ## Using variant classes diff --git a/src/components/table/README.md b/src/components/table/README.md index 4ac0b0bf622..0ef7aa5e339 100644 --- a/src/components/table/README.md +++ b/src/components/table/README.md @@ -1525,11 +1525,18 @@ element. Rows that are selected rows will have a class of `b-row-selected` appli element. Use the prop `selected-variant` to apply a Bootstrap theme color to the selected row(s). Note, due -to the order that the table variants are defined in Bootstrap's CSS, any row-variant may take +to the order that the table variants are defined in Bootstrap's CSS, any row-variant _might_ take precedence over the `selected-variant`. You can set `selected-variant` to an empty string if you will be using other means to convey that a row is selected (such as a scoped field slot in the below example). +The `selected-variant` can be any of the +[standard (or custom) bootstrap base color variants](/docs/reference/color-variants), or the special +[table `active` variant](/docs/reference/color-variants#table-variants). + +For accessibility reasons (specifically for color blind users), it is highly recommended to always +provide some other visual means of conveying that a row is selected, as shown in the example below. + ```html