-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore: code size improvements #5151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5151 +/- ##
===========================================
- Coverage 100.00% 99.87% -0.13%
===========================================
Files 277 289 +12
Lines 8867 9108 +241
Branches 2490 2504 +14
===========================================
+ Hits 8867 9097 +230
- Misses 0 11 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Side thought: Bundlewatch appears to always compare to the base branch
Is it possible to get it to compare aginst the target branch of the PR? i.e. this PR would compare against Or maybe generate two bundle watches... one that compares with master and one that compares with dev? |
This reverts commit b36a479.
Describe the PR
This PR makes some adjustments to the code to decrease overall bundle size (specifically after minimization).
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: