Skip to content

chore: code size improvements #5151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 75 commits into from
Closed

Conversation

jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented Apr 15, 2020

Describe the PR

This PR makes some adjustments to the code to decrease overall bundle size (specifically after minimization).

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe) refactor

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #5151 into dev will decrease coverage by 0.12%.
The diff coverage is 98.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev    #5151      +/-   ##
===========================================
- Coverage   100.00%   99.87%   -0.13%     
===========================================
  Files          277      289      +12     
  Lines         8867     9108     +241     
  Branches      2490     2504      +14     
===========================================
+ Hits          8867     9097     +230     
- Misses           0       11      +11     
Flag Coverage Δ
#unittests 99.87% <98.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/breadcrumb/breadcrumb-item.js 100.00% <ø> (ø)
src/components/card/card-footer.js 100.00% <ø> (ø)
src/components/card/card-header.js 100.00% <ø> (ø)
...components/form-select/form-select-option-group.js 100.00% <ø> (ø)
src/components/form-select/form-select-option.js 100.00% <ø> (ø)
src/components/form-textarea/form-textarea.js 100.00% <ø> (ø)
src/components/image/img.js 100.00% <ø> (ø)
src/components/input-group/input-group-addon.js 100.00% <ø> (ø)
src/components/input-group/input-group-append.js 100.00% <ø> (ø)
src/components/input-group/input-group-prepend.js 100.00% <ø> (ø)
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a948846...9add554. Read the comment docs.

@tmorehouse tmorehouse changed the title feat: code size improvements chore: code size improvements Apr 15, 2020
@tmorehouse tmorehouse self-requested a review April 15, 2020 07:36
@tmorehouse tmorehouse marked this pull request as draft April 15, 2020 08:33
@tmorehouse
Copy link
Member

tmorehouse commented Apr 15, 2020

Side thought: Bundlewatch appears to always compare to the base branch master

[ERROR] Unable to fetch fileDetails for baseBranch=master from https://service.bundlewatch.io/store code=Request failed with status code 404

Is it possible to get it to compare aginst the target branch of the PR?

i.e. this PR would compare against dev, while the release PR would compare against master?

Or maybe generate two bundle watches... one that compares with master and one that compares with dev?

This reverts commit b36a479.
@vercel vercel bot temporarily deployed to Preview May 10, 2020 23:49 Inactive
@vercel vercel bot temporarily deployed to Preview May 15, 2020 08:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants