-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(b-link): add support 3rd party router links such as Gridsome's <g-link>
(closes #2627)
#5358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/2tdap1zom |
<g-link>
<g-link>
(closes #2627)
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c3f9077:
|
Codecov Report
@@ Coverage Diff @@
## dev #5358 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 281 281
Lines 8835 8835
Branches 2501 2501
=========================================
Hits 8835 8835
Continue to review full report at Codecov.
|
@jackmu95 thinking we should Or perhaps remove it from |
Describe the PR
Adds a new prop
router-component-name
, which defaults toundefined
.Default is to auto detect
<router-link>
or<nuxt-link>
.Gridsome does not provide a means for detecting that the app is running under Gridsome, so users who wish to use
<g-link>
can set this prop to'g-link'
Notes:
vue-router
is not detected, then the user supplied router-link component will not be used.g-link
is not a registered component, then the render or the link will fail<g-link>
component does not support FQDN URLs nor hash only URLs (https://gridsome.org/docs/linking/)To Do:
Possible ToDo:
<router-link>
Closes #2627
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: