Skip to content

fix(b-form-datepicker/b-form-timepicker/b-nav-item-dropdown): dropdown positioning handling (closes #5700, #5630) #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 13, 2020
Merged

fix(b-form-datepicker/b-form-timepicker/b-nav-item-dropdown): dropdown positioning handling (closes #5700, #5630) #5765

merged 7 commits into from
Sep 13, 2020

Conversation

jacobmllr95
Copy link
Member

Describe the PR

This PR fixes the dropdown positioning handling fro other components that rely on it.
Currently these are <b-form-datepicker>, <b-form-timepicker> and <b-nav-item-dropdown>.

While at it, it also improves the documentation for popper-opts and links to the <b-dropdown> positioning section from the other components.

Closes #5700.
Closes #5630.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 added Type: Docs Type: Fix PR: Patch Requires patch version bump labels Sep 11, 2020
@jacobmllr95 jacobmllr95 requested a review from Hiws September 11, 2020 15:32
@vercel
Copy link

vercel bot commented Sep 11, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/655pp5319
✅ Preview: https://bootstrap-vue-git-fix-dropdown-placemnet-for-other-components.bootstrap-vue.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 11, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ec29d9:

Sandbox Source
BootstrapVue Starter Project Configuration

@codecov
Copy link

codecov bot commented Sep 11, 2020 •
edited
Loading

Codecov Report

Merging #5765 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5765   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          284       284           
  Lines         9640      9655   +15     
  Branches      2551      2555    +4     
=========================================
+ Hits          9640      9655   +15
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/bv-form-btn-label-control.js 100.00% <ø> (ø)
src/components/dropdown/dropdown.js 100.00% <100.00%> (ø)
src/components/nav/nav-item-dropdown.js 100.00% <100.00%> (ø)
src/mixins/dropdown.js 100.00% <100.00%> (ø)
src/utils/events.js 100.00% <100.00%> (ø)
src/utils/object.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949ecf7...6ec29d9. Read the comment docs.

Hiws
Hiws requested changes Sep 12, 2020
View reviewed changes
Copy link
Member

@Hiws Hiws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the calendar doesn't open when you click on the input field in <b-form-datepicker>, only opens if you click the icon directly.

Looks like it's happening on dev too, so doesn't look like it's introduced by this PR.
Is that a thing that was intentionally changed recently?

@jacobmllr95
Copy link
Member Author

Looks like it's happening on dev too, so doesn't look like it's introduced by this PR.
Is that a thing that was intentionally changed recently?

Good catch. The bug was introduced with the stopEvent() util in #5727.
Fixed it with this PR.

@jacobmllr95 jacobmllr95 requested a review from Hiws September 13, 2020 09:04
@vercel vercel bot temporarily deployed to Preview September 13, 2020 09:08 Inactive
@jacobmllr95 jacobmllr95 merged commit 7ec2205 into dev Sep 13, 2020
@jacobmllr95 jacobmllr95 deleted the fix-dropdown-placemnet-for-other-components branch September 13, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiws Hiws Hiws approved these changes

Assignees
No one assigned
Labels
PR: Patch Requires patch version bump Type: Docs Type: Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to set "boundary" property for Form DatePicker component How to configure popper-opts
2 participants
@jacobmllr95 @Hiws