Skip to content

fix(BTable): reflect single select mode on programmatic selection #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

oliver681
Copy link
Contributor

Describe the PR

closes #2433

This pull request changes the behavior when programmatically selecting a row in a BTable:

If the select mode is "single":

  • only the row with the passed id will be selected
  • selectAllRows() will return without performing an action

Small replication

See: #2433

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

pkg-pr-new bot commented Dec 10, 2024

Open in Stackblitz

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2440
npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2440

commit: 5c37435

@VividLemon VividLemon merged commit 1ea89dc into bootstrap-vue-next:main Dec 11, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exposed method selectRow(index) does not reflect single select mode
2 participants