Skip to content

fix(BTable): make foot props and slot fall back to head if not defined #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2025

Conversation

dwgray
Copy link
Member

@dwgray dwgray commented Mar 17, 2025

Describe the PR

fixes #2538

  • If footVariant, footRowVariant, footClass and footTrClass aren't specified, fall back to the equivalent head props.
  • If the foot() or foot(*) slot isn't defined, fall back to the equivalent head slot
    • Add some documentation to how this fallback works, as I misread the BSV docs and implemented it incorrectly the first time
  • Add unit tests for this and related behavior

Small replication

See unit tests in this PR

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

pkg-pr-new bot commented Mar 17, 2025

Open in Stackblitzbsvn-vite-ts

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2614
npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2614

commit: 43f697d

@dwgray dwgray marked this pull request as draft March 18, 2025 22:36
@dwgray dwgray marked this pull request as ready for review March 19, 2025 20:38
@dwgray dwgray merged commit 05fffbb into bootstrap-vue-next:main Mar 28, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 28, 2025
@dwgray dwgray deleted the foot-fallback branch April 22, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Table footer props and slots fall back to header definitions
2 participants