disallow untyped calls in autocomplete.py

thomasballinger · thomasballinger · commit 1ad2ba457f0f · 2021-10-08T10:44:25.000-07:00
diff --git a/bpython/autocomplete.py b/bpython/autocomplete.py
@@ -23,6 +23,7 @@
 
 # To gradually migrate to mypy we aren't setting these globally yet
 # mypy: disallow_untyped_defs=True
+# mypy: disallow_untyped_calls=True
 
 import __main__
 import abc
diff --git a/bpython/inspection.py b/bpython/inspection.py
@@ -347,7 +347,7 @@ def get_encoding_file(fname):
     return "utf8"
 
 
-def getattr_safe(obj, name):
+def getattr_safe(obj: Any, name: str):
     """side effect free getattr (calls getattr_static)."""
     result = inspect.getattr_static(obj, name)
     # Slots are a MemberDescriptorType
@@ -356,7 +356,7 @@ def getattr_safe(obj, name):
     return result
 
 
-def hasattr_safe(obj, name):
+def hasattr_safe(obj: Any, name: str) -> bool:
     try:
         getattr_safe(obj, name)
         return True
diff --git a/bpython/simpleeval.py b/bpython/simpleeval.py
@@ -28,6 +28,7 @@
 import ast
 import sys
 import builtins
+from typing import Dict, Any
 
 from . import line as line_properties
 from .inspection import getattr_safe
@@ -44,7 +45,7 @@ class EvaluationError(Exception):
     """Raised if an exception occurred in safe_eval."""
 
 
-def safe_eval(expr, namespace):
+def safe_eval(expr: str, namespace: Dict[str, Any]) -> Any:
     """Not all that safe, just catches some errors"""
     try:
         return eval(expr, namespace)
@@ -214,7 +215,9 @@ def find_attribute_with_name(node, name):
             return r
 
 
-def evaluate_current_expression(cursor_offset, line, namespace=None):
+def evaluate_current_expression(
+    cursor_offset: int, line: str, namespace: Dict[str, Any] = None
+):
     """
     Return evaluated expression to the right of the dot of current attribute.
 
