Skip to content

Add workaround for CPython issue #10509 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ikanobori opened this issue Jul 4, 2014 · 7 comments
Closed

Add workaround for CPython issue #10509 #166

ikanobori opened this issue Jul 4, 2014 · 7 comments
Labels
enhancement

Comments

@ikanobori
Copy link
Contributor

Seee http://bugs.python.org/issue10509. If it doesn't get fixed in 3.2, we probably need some workaround. Otherwise, bpython can crash while initialising its import completion, which is quite bad (as I don't think that import completion can be turned off right now).
@ikanobori
Copy link
Contributor Author

Issue #189 was marked as a duplicate of this issue.

Original Comment By: Andreas Stührk

@ikanobori
Copy link
Contributor Author

Fixed upstream (http://hg.python.org/cpython/rev/fa5e348889c2) in 3.2 as well. As it will be fixed in the next Python 3.2 release and we have a workaround for the most common case, I'll close this issue.

Original Comment By: Andreas Stührk

@ikanobori
Copy link
Contributor Author

I added a workaround for the most common case in <<changeset 1f9c109f0d1d>>.

Original Comment By: Andreas Stührk

@ikanobori
Copy link
Contributor Author

Unfortunately, this might not be as easy that I thought, as //importlib// seems to implement some stuff as internal API only.

Original Comment By: Andreas Stührk

@ikanobori
Copy link
Contributor Author

I think we should rather use //importlib// instead of that crazy patch.

Original Comment By: Andreas Stührk

@ikanobori
Copy link
Contributor Author

Patch at http://bpaste.net/show/14319/

Original Comment By: Andreas Stührk

@ikanobori
Copy link
Contributor Author

It didn't get fixed. Also, someone complained on IRC about it. We should add a workaround.

Original Comment By: Andreas Stührk

@ikanobori ikanobori mentioned this issue Jul 4, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ikanobori