Skip to content

Regression introduced by 648d0b200ae896c3384e576b6df8d2b00d622f21 #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sebastinas opened this issue Feb 3, 2015 · 1 comment
Closed

Regression introduced by 648d0b200ae896c3384e576b6df8d2b00d622f21 #472

sebastinas opened this issue Feb 3, 2015 · 1 comment
Assignees
@thomasballinger
Labels
bug
Milestone
0.14

Comments

@sebastinas
Copy link
Contributor

Enter max('', *[], key=len) and execute it. Now go back in the history (arrow up), change *[] to '2' and execute it again. Notice how it executes the correct code, but the line changes back to max('', *[], key=len).

A git bisect say that the issue was introduced in 648d0b2.
@sebastinas sebastinas added the bug label Feb 3, 2015
@sebastinas sebastinas added this to the 0.14 milestone Feb 3, 2015
@thomasballinger
Copy link
Member

This is due to unhighlight_paren, but hard to imagine how the code in 648d0b2 is responsible. Reminder to me to write a test for it before trying to fix it!

thomasballinger added a commit that referenced this issue Feb 4, 2015
@thomasballinger
test for issue #472
b85f0b8 
Appears to be causes by unhighlight paren repainting the wrong tokens
thomasballinger added a commit that referenced this issue Feb 6, 2015
@thomasballinger
Fix #468 and #472 highlight paren bug
3310325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasballinger thomasballinger

Labels
bug
Projects
None yet
Milestone
0.14
Development

No branches or pull requests
2 participants
@sebastinas @thomasballinger