-
-
Notifications
You must be signed in to change notification settings - Fork 245
TypeError: a bytes-like object is required, not 'str' #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @gordio! Could you check, whether the issue is still present with the latest (0.17) release? |
@ata2001 yep, still exist on |
So if I understand it correctly, this software is trying to write binary data to the stdout to display an image? @thomasballinger We could put a try except structure in |
Yep. |
@gordio Please apply this patch, run bpython with the |
bpython.log!
|
@gordio Thank you! The error comes from bpython trying to split the image with a string as a separator. Is there any way, I could test it on a GNU/linux system? |
I don't know. But you can install https://github.com/daleroberts/itermplot and test. |
Hmmmmm so we ought to be allowing bytes to pass through huh? This actually may be related to a unicode width-predicting issue I'm hoping to look at: there are some things like escape codes and binary image data that make predicting what the terminal will look like difficult for bpython, so maybe we should just be printing and then seeing where the cursor is. That said, I think the odds of this being supported in curtsies are pretty low, it seems like it could interfere with the terminal-rewriting rewind behavior I'm unreasonably fond of. |
Should I open a new issue or contribute here, I get this error when trying to use the click library. It happens if I first import click and then |
@slipsnip Please open a new issue, that sounds easier to address (and more urgent) |
This was fixed in b63051e. |
You may understand…
The text was updated successfully, but these errors were encountered: