Skip to content

Commit 0e7939f

Browse files
committed
Merge pull request NativeScript#113 from NativeScript/feature/page-router-as-root-2
Allow page outlet ate root and clean up the visual tree
2 parents 8ea0714 + 8858f07 commit 0e7939f

File tree

6 files changed

+418
-216
lines changed

6 files changed

+418
-216
lines changed

ng-sample/app/examples/navigation/navigation-test.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,7 @@ class StartComponent {
3131
@Component({
3232
selector: 'navigation-test',
3333
directives: [NS_ROUTER_DIRECTIVES],
34-
template: `
35-
<GridLayout>
36-
<page-router-outlet></page-router-outlet>
37-
</GridLayout>
38-
`
34+
template: `<page-router-outlet></page-router-outlet>`
3935
})
4036
@RouteConfig([
4137
{ path: '/', component: StartComponent, as: 'Start' },
@@ -44,4 +40,3 @@ class StartComponent {
4440
export class NavigationTest {
4541

4642
}
47-

src/nativescript-angular/element-registry.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,3 +99,5 @@ registerElement("TextView", () => require("ui/text-view").TextView);
9999
registerElement("TimePicker", () => require("ui/time-picker").TimePicker);
100100
registerElement("WebView", () => require("ui/web-view").WebView);
101101
registerElement("WrapLayout", () => require("ui/layouts/wrap-layout").WrapLayout);
102+
103+
registerElement("DetachedContainer", () => require("ui/proxy-view-container").ProxyViewContainer, { skipAddToDom: true });

0 commit comments

Comments
 (0)