From b477cb659c6fc42ac4928a8a0292cf56d248291c Mon Sep 17 00:00:00 2001 From: 0x8890 <0x8890@airmail.cc> Date: Sat, 2 Jul 2016 00:23:46 +0200 Subject: [PATCH 1/2] accept connection parameters in pool constructor --- lib/pool-factory.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/pool-factory.js b/lib/pool-factory.js index aa7bd0b19..11ca16aed 100644 --- a/lib/pool-factory.js +++ b/lib/pool-factory.js @@ -1,11 +1,13 @@ var Client = require('./client'); +var ConnectionParameters = require('./connection-parameters'); var util = require('util'); var Pool = require('pg-pool'); module.exports = function(Client) { var BoundPool = function(options) { - var config = { Client: Client }; + var config = new ConnectionParameters(options); + config.Client = Client; for (var key in options) { config[key] = options[key]; } From 8f4b15e3f760a4320439eb58b799157a1fb45f99 Mon Sep 17 00:00:00 2001 From: 0x8890 <0x8890@airmail.cc> Date: Mon, 4 Jul 2016 13:07:10 +0200 Subject: [PATCH 2/2] remove unnecessary for loop --- lib/pool-factory.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/pool-factory.js b/lib/pool-factory.js index 11ca16aed..56d549262 100644 --- a/lib/pool-factory.js +++ b/lib/pool-factory.js @@ -8,9 +8,6 @@ module.exports = function(Client) { var BoundPool = function(options) { var config = new ConnectionParameters(options); config.Client = Client; - for (var key in options) { - config[key] = options[key]; - } Pool.call(this, config); };