@brianc @strk @cdauth sorry i'm late to the discussion here. I just updated to the latest pg and was broken by this change. I may be missing something here, but i feel like the original behavior prior to this change was far superior.

In our projects, we always store timestamps as UTC in the database, using the data type timestamp without timezone. The client code accessing the db may be running in any arbitrary timezone of course, and so we completely ignore timezones and just use Date.getTime() when comparing or otherwise manipulating timestamps, so everything is manipulated UTC as well. I think this is a fairly common pattern? However, with this change to pg, from a client with a non-UTC timezone if i store a timestamp and then read it back, i get a different value from getTime() because it has been shifted based on the local timezone. I do see the discussion in PR #237 (and I wasn't sure which thread to put this comment on... my apologies).

I do not want to change all the database types to timestamp with timezone in the schema for several reasons:

if PR Fix handling of timestamp fields without timezone #237 goes in, we will end up with timestamps in all sorts of timezones in the database based on the local timezones of the clients, which breaks our design goal of all UTC in the db
its a substantial change (there is other non-node code that accesses the database, etc.)

I looked at overriding the timezone of the clients to be UTC, but there are issues with that:nodejs/node-v0.x-archive#3286

How do you propose we work around this?

Thanks,
Seth

Uh oh!

timestamp without timezone is parsed as if it had a timezone #225

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions