Skip to content

Add a license comment to a source code #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kitakappa
Copy link

This PR makes the open source licensing clearer.

  • Add license header comments to source code files.

@brianc
Copy link
Owner

brianc commented Jun 7, 2016

Is there a reason for this? I'm not a fan of license headers in every source file.

@kitakappa
Copy link
Author

The reason.. To use this in more people.
License header is necessary for by 1 file when I want to use OSS in a stubborn company :l
In addition, even if a file fall away from package, a license is clear.

I think license header is redundant, but think that it is good if users increase.

@brianc
Copy link
Owner

brianc commented Jun 10, 2016

@kitakappa if this will make it easier for you to use this at your company I'll merge it in, just for you. ;)

@kitakappa
Copy link
Author

@brianc Thank you for consideration. Yes, legal department in my company is very very stubborn. :X
I'm so happy if merge this. :)

@brianc
Copy link
Owner

brianc commented Jun 21, 2016

Hey @kitakappa - I made some changes which caused a merge conflict here. :( Sorry about that - if you can resolve the merge conflict I'll get this merged into the code base ASAP!

@illiriks
Copy link
Contributor

illiriks commented Jun 24, 2016

Hey; I resolved the merge conflict (one file was rmed). It's PR #1065

brianc pushed a commit that referenced this pull request Jun 24, 2016
* Add license comment

* Delete pool.js
@brianc
Copy link
Owner

brianc commented Jun 24, 2016

Closed with #1065

@brianc brianc closed this Jun 24, 2016
@kitakappa
Copy link
Author

@brianc @illiriks Sorry to be late. Thank you for fix conflict and marge 👍
It was saved very much. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants