Skip to content

Close connection on SSL connection errors #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 29, 2020
Merged

Close connection on SSL connection errors #2082

merged 5 commits into from
Jan 29, 2020

Conversation

brianc
Copy link
Owner

@brianc brianc commented Jan 28, 2020

Fixes #2079

charmander
charmander requested changes Jan 28, 2020
View reviewed changes
charmander
charmander approved these changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@charmander charmander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s probably fine to clean up event edge case consistency later. (It looks like 'end' might be emitted twice normally anyway?)

@brianc
Copy link
Owner Author

brianc commented Jan 28, 2020

It’s probably fine to clean up event edge case consistency later. (It looks like 'end' might be emitted twice normally anyway?)

ha yeah i just saw that - so yeah I'm punting on that. Technically the stream did "end" since it did also technically "connect" - but emitting twice isn't nice.

@brianc brianc force-pushed the bmc/ssl-connection-error-unref branch from 7e9bd3f to b3c0874 Compare January 28, 2020 18:32
@brianc brianc merged commit 11ab1da into master Jan 29, 2020
@brianc brianc deleted the bmc/ssl-connection-error-unref branch January 29, 2020 16:18
@eugene1g eugene1g mentioned this pull request Jan 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmander charmander charmander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jest reports open handlers when connecting with ssl=true to a local PostgreSQL (no SSL support)
2 participants
@brianc @charmander