Skip to content

Adding pg to peerDependencies #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2021
Merged

Adding pg to peerDependencies #2471

merged 2 commits into from
Mar 12, 2021

Conversation

ed0wolf
Copy link
Contributor

@ed0wolf ed0wolf commented Feb 13, 2021 •
edited
Loading

Yarn2 requires strict imports, I.E. all project dependencies need to exist in that project's package.json.

Required package: pg (via "pg/lib/result.js")
Required by: pg-cursor@npm:2.5.2 (via ....../.yarn/cache/pg-cursor-npm-2.5.2-b99730336d-1735cfa9a6.zip/node_modules/pg-cursor/)

@ed0wolf
Adding pg to peerDependencies
c583d14 
Yarn2 requires strict imports, I.E. all project dependencies need to exist in that project's package.json.
@charmander charmander linked an issue Feb 13, 2021 that may be closed by this pull request
Required dependencies as devDependencies in pg-cursor #2249
Closed
charmander
charmander requested changes Feb 13, 2021
View reviewed changes
@ed0wolf @charmander
pg version should be locked on the major version
515b6b4 
Co-authored-by: Charmander <~@charmander.me>
@brianc
Copy link
Owner

brianc commented Mar 12, 2021

thanks! Sorry for the delay - had a bunch of stuff happen in my life all at once so I had to take a computer break for a few weeks.

@brianc brianc merged commit 2a7c614 into brianc:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmander charmander charmander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required dependencies as devDependencies in pg-cursor
3 participants
@ed0wolf @brianc @charmander