DX: re-apply PHP CS Fixer, partially

keradus · nicolas-grekas · commit 110d13b598c6 · 2023-11-01T13:07:38.000+01:00
diff --git a/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/ProxyDumperTest.php b/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/ProxyDumperTest.php
@@ -93,7 +93,7 @@ public static function getPrivatePublicDefinitions()
     {
         return [
             [
-                (new Definition(__CLASS__)),
+                new Definition(__CLASS__),
                 'privates',
             ],
             [
diff --git a/src/Symfony/Bundle/DebugBundle/DependencyInjection/DebugExtension.php b/src/Symfony/Bundle/DebugBundle/DependencyInjection/DebugExtension.php
@@ -20,7 +20,6 @@
 use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\VarDumper\Caster\ReflectionCaster;
-use Symfony\Component\VarDumper\Dumper\HtmlDumper;
 
 /**
  * DebugExtension.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/TestBundle.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/TestBundle.php
@@ -11,7 +11,6 @@
 
 namespace Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle;
 
-use Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle\DependencyInjection\AnnotationReaderPass;
 use Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle\DependencyInjection\Config\CustomConfig;
 use Symfony\Component\DependencyInjection\Compiler\CheckTypeDeclarationsPass;
 use Symfony\Component\DependencyInjection\Compiler\PassConfig;
diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -352,7 +352,7 @@ public function testFindInvalidNamespace()
         $this->expectException(NamespaceNotFoundException::class);
         $this->expectExceptionMessage('There are no commands defined in the "bar" namespace.');
 
-        (new Application)->findNamespace('bar');
+        (new Application())->findNamespace('bar');
     }
 
     public function testFindUniqueNameButNamespaceName()
diff --git a/src/Symfony/Component/HttpClient/NativeHttpClient.php b/src/Symfony/Component/HttpClient/NativeHttpClient.php
@@ -203,9 +203,14 @@ public function request(string $method, string $url, array $options = []): Respo
         }
 
         switch ($cryptoMethod = $options['crypto_method']) {
-            case \STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT: $cryptoMethod |= \STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT;
-            case \STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT: $cryptoMethod |= \STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT;
-            case \STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT: $cryptoMethod |= \STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT;
+            case \STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT:
+                $cryptoMethod |= \STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT;
+                // no break
+            case \STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT:
+                $cryptoMethod |= \STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT;
+                // no break
+            case \STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT:
+                $cryptoMethod |= \STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT;
         }
 
         $context = [
diff --git a/src/Symfony/Component/HttpClient/Psr18Client.php b/src/Symfony/Component/HttpClient/Psr18Client.php
@@ -28,11 +28,8 @@
 use Psr\Http\Message\UriFactoryInterface;
 use Psr\Http\Message\UriInterface;
 use Symfony\Component\HttpClient\Internal\HttplugWaitLoop;
-use Symfony\Component\HttpClient\Response\StreamableInterface;
-use Symfony\Component\HttpClient\Response\StreamWrapper;
 use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
-use Symfony\Contracts\HttpClient\ResponseInterface as HttpClientResponseInterface;
 use Symfony\Contracts\Service\ResetInterface;
 
 if (!interface_exists(ClientInterface::class)) {
diff --git a/src/Symfony/Component/Ldap/Adapter/ConnectionInterface.php b/src/Symfony/Component/Ldap/Adapter/ConnectionInterface.php
@@ -28,11 +28,11 @@ public function isBound(): bool;
     /**
      * Binds the connection against a user's DN and password.
      *
+     * @return void
+     *
      * @throws AlreadyExistsException      When the connection can't be created because of an LDAP_ALREADY_EXISTS error
      * @throws ConnectionTimeoutException  When the connection can't be created because of an LDAP_TIMEOUT error
      * @throws InvalidCredentialsException When the connection can't be created because of an LDAP_INVALID_CREDENTIALS error
-     *
-     * @return void
      */
     public function bind(string $dn = null, #[\SensitiveParameter] string $password = null);
 }
diff --git a/src/Symfony/Component/Ldap/LdapInterface.php b/src/Symfony/Component/Ldap/LdapInterface.php
@@ -28,9 +28,9 @@ interface LdapInterface
     /**
      * Return a connection bound to the ldap.
      *
-     * @throws ConnectionException if dn / password could not be bound
-     *
      * @return void
+     *
+     * @throws ConnectionException if dn / password could not be bound
      */
     public function bind(string $dn = null, #[\SensitiveParameter] string $password = null);
 
diff --git a/src/Symfony/Component/Validator/Resources/bin/sync-iban-formats.php b/src/Symfony/Component/Validator/Resources/bin/sync-iban-formats.php
@@ -187,7 +187,7 @@ private function readIbanFormatsTable(): array
     {
         $tablesResponse = file_get_contents('https://www.wikitable2json.com/api/International_Bank_Account_Number?table=3&keyRows=1&clearRef=true');
 
-        return json_decode($tablesResponse, true, 512, JSON_THROW_ON_ERROR)[0];
+        return json_decode($tablesResponse, true, 512, \JSON_THROW_ON_ERROR)[0];
     }
 
     private function buildIbanRegexp(string $countryCode, string $bbanFormat): string

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public static function getPrivatePublicDefinitions()`
`93`	`93`	`{`
`94`	`94`	`return [`
`95`	`95`	`[`
`96`		`- (new Definition(__CLASS__)),`
	`96`	`+ new Definition(__CLASS__),`
`97`	`97`	`'privates',`
`98`	`98`	`],`
`99`	`99`	`[`
Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ public function testFindInvalidNamespace()`
`352`	`352`	`$this->expectException(NamespaceNotFoundException::class);`
`353`	`353`	`$this->expectExceptionMessage('There are no commands defined in the "bar" namespace.');`
`354`	`354`
`355`		`- (new Application)->findNamespace('bar');`
	`355`	`+ (new Application())->findNamespace('bar');`
`356`	`356`	`}`
`357`	`357`
`358`	`358`	`public function testFindUniqueNameButNamespaceName()`
Original file line number	Diff line number	Diff line change
`@@ -28,11 +28,11 @@ public function isBound(): bool;`
`28`	`28`	`/**`
`29`	`29`	`* Binds the connection against a user's DN and password.`
`30`	`30`	`*`
	`31`	`+ * @return void`
	`32`	`+ *`
`31`	`33`	`* @throws AlreadyExistsException When the connection can't be created because of an LDAP_ALREADY_EXISTS error`
`32`	`34`	`* @throws ConnectionTimeoutException When the connection can't be created because of an LDAP_TIMEOUT error`
`33`	`35`	`* @throws InvalidCredentialsException When the connection can't be created because of an LDAP_INVALID_CREDENTIALS error`
`34`		`- *`
`35`		`- * @return void`
`36`	`36`	`*/`
`37`	`37`	`public function bind(string $dn = null, #[\SensitiveParameter] string $password = null);`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ private function readIbanFormatsTable(): array`
`187`	`187`	`{`
`188`	`188`	`$tablesResponse = file_get_contents('https://www.wikitable2json.com/api/International_Bank_Account_Number?table=3&keyRows=1&clearRef=true');`
`189`	`189`
`190`		`- return json_decode($tablesResponse, true, 512, JSON_THROW_ON_ERROR)[0];`
	`190`	`+ return json_decode($tablesResponse, true, 512, \JSON_THROW_ON_ERROR)[0];`
`191`	`191`	`}`
`192`	`192`
`193`	`193`	`private function buildIbanRegexp(string $countryCode, string $bbanFormat): string`