bug symfony#31863 [HttpFoundation] Fixed case-sensitive handling of cache-control header in RedirectResponse constructor (Ivo)

fabpot · fabpot · commit 11f04abcd428 · 2019-06-05T15:24:38.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Fixed case-sensitive handling of cache-control header in RedirectResponse constructor …r in RedirectResponse constructor. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? |no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | symfony#31862  | License | MIT Perform a case-insensitive check on `$headers` in \Symfony\Component\HttpFoundation\RedirectResponse::__construct() Commits ------- b5e6c99 [HttpFoundation] Fixed case-sensitive handling of cache-control header in RedirectResponse constructor.
diff --git a/src/Symfony/Component/HttpFoundation/RedirectResponse.php b/src/Symfony/Component/HttpFoundation/RedirectResponse.php
@@ -42,7 +42,7 @@ public function __construct($url, $status = 302, $headers = [])
             throw new \InvalidArgumentException(sprintf('The HTTP status code is not a redirect ("%s" given).', $status));
         }
 
-        if (301 == $status && !\array_key_exists('cache-control', $headers)) {
+        if (301 == $status && !\array_key_exists('cache-control', array_change_key_case($headers, \CASE_LOWER))) {
             $this->headers->remove('cache-control');
         }
     }
diff --git a/src/Symfony/Component/HttpFoundation/Tests/RedirectResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/RedirectResponseTest.php
@@ -91,6 +91,10 @@ public function testCacheHeaders()
         $this->assertFalse($response->headers->hasCacheControlDirective('no-cache'));
         $this->assertTrue($response->headers->hasCacheControlDirective('max-age'));
 
+        $response = new RedirectResponse('foo.bar', 301, ['Cache-Control' => 'max-age=86400']);
+        $this->assertFalse($response->headers->hasCacheControlDirective('no-cache'));
+        $this->assertTrue($response->headers->hasCacheControlDirective('max-age'));
+
         $response = new RedirectResponse('foo.bar', 302);
         $this->assertTrue($response->headers->hasCacheControlDirective('no-cache'));
     }

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function __construct($url, $status = 302, $headers = [])`
`42`	`42`	`throw new \InvalidArgumentException(sprintf('The HTTP status code is not a redirect ("%s" given).', $status));`
`43`	`43`	`}`
`44`	`44`
`45`		`- if (301 == $status && !\array_key_exists('cache-control', $headers)) {`
	`45`	`+ if (301 == $status && !\array_key_exists('cache-control', array_change_key_case($headers, \CASE_LOWER))) {`
`46`	`46`	`$this->headers->remove('cache-control');`
`47`	`47`	`}`
`48`	`48`	`}`